Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Siedlerchr @cMadan I guess I can explain what happens and it looks like the mistake is coming from de.undercouch.citeproc.bibtex.BibTeXConverter#toItemData(org.jbibtex.BibTeXEntry). The rundown is as follows: #6041

Closed
Siedlerchr opened this issue Feb 28, 2020 · 0 comments

Comments

@Siedlerchr
Copy link
Member

@Siedlerchr @cMadan I guess I can explain what happens and it looks like the mistake is coming from de.undercouch.citeproc.bibtex.BibTeXConverter#toItemData(org.jbibtex.BibTeXEntry). The rundown is as follows:

  • User clicks on an entry which is then sent to create the preview.
  • We create an org.jbibtex.BibTeXEntry instance from the information we have. Since we only have the journal name in one field, we create only one field inside this BibTeXEntry with key "journal` (or smth similar) and the name of the journal as value
  • This created instance is sent to de.undercouch.citeproc.bibtex.BibTeXConverter#toItemData(org.jbibtex.BibTeXEntry) which creates the representation that is used in the CSL formatting engine

The last step creates the following representation for a simple article entry. Please note the double entry collection-title and container-title. When you look at the .csl file you can easily spot what happens. There is a macro containter with several conditional expressions. An "article" goes to the last else branch which states

<else>
    <group prefix=". " suffix="," delimiter=", ">
        <text variable="container-title" form="short" font-style="italic"/>
        <text variable="collection-title"/>
    </group>
</else>

My guess is that this is really meant to contain the Journal name and the Collection name, but I'm unable to create an example where this works. I tried with an example of InCollection but I always end up with a double "BookTitle".

Originally posted by @halirutan in #3259 (comment)

koppor pushed a commit that referenced this issue Jul 15, 2022
39fede5 Update associacao-brasileira-de-normas-tecnicas.csl (#6138)
fde7695 Include chapter title (#6140)
1e3d8b4 Update n.d. abbreivation for DGP style (#6136)
ebb728b suffix '.' after first group; changed e-mail (#6135)
eed4f07 Update and rename sciences-po-ecole-doctorale-note-french.csl to scie… (#6127)
f194647 Delete TU Dresden Medizin as requested by library (#6131)
d8423d8 Create entomological-review.csl (#6120)
064a394 Create australasian-journal-of-philosophy.csl (#6063)
a998ded Add composer.json (#5668)
37083c9 Update copernicus-publications.csl (#6062)
694c97b Create chaucer review (#6061)
625a424 Create haffner-style-manual.csl (#6054)
8b7224b make annals-of-allergy-asthma-and-immunology independent (#6041)
710748c Create university-of-pretoria-harvard-theology-religion.csl (#6106)
d16dffd Create health-physics.csl (#6040)
ca9e184 Update style-manual-australian-government.csl (#6119)
e412277 Create chemical-engineering-technology.csl (#6039)
bebdb48 Create bibliothek-forschung-und-praxis.csl (#6038)
29e49cd Update nature.csl (#6117)
891897d fix short title for SBL (#6118)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 39fede5
koppor pushed a commit that referenced this issue Aug 1, 2022
c750b6e APA: Put conditional event-title logic in a macro (#6161)
a87414f Remove month from association-for-compuational-linguistics.csl (#6158)
6153db0 Remove issue numbers from BJOC style (#6155)
e231ea3 Bug fix for `event` regression (#6154)
0dab651 Add event-title to other APA styles (#6153)
698cf1c APA: `event-title` and conditional `event` (#6152)
58d3f8f Update vancouver-author-date.csl (#6148)
f1638a9 add substitute to Vancouver author date (#6147)
39fede5 Update associacao-brasileira-de-normas-tecnicas.csl (#6138)
fde7695 Include chapter title (#6140)
1e3d8b4 Update n.d. abbreivation for DGP style (#6136)
ebb728b suffix '.' after first group; changed e-mail (#6135)
eed4f07 Update and rename sciences-po-ecole-doctorale-note-french.csl to scie… (#6127)
f194647 Delete TU Dresden Medizin as requested by library (#6131)
d8423d8 Create entomological-review.csl (#6120)
064a394 Create australasian-journal-of-philosophy.csl (#6063)
a998ded Add composer.json (#5668)
37083c9 Update copernicus-publications.csl (#6062)
694c97b Create chaucer review (#6061)
625a424 Create haffner-style-manual.csl (#6054)
8b7224b make annals-of-allergy-asthma-and-immunology independent (#6041)
710748c Create university-of-pretoria-harvard-theology-religion.csl (#6106)
d16dffd Create health-physics.csl (#6040)
ca9e184 Update style-manual-australian-government.csl (#6119)
e412277 Create chemical-engineering-technology.csl (#6039)
bebdb48 Create bibliothek-forschung-und-praxis.csl (#6038)
29e49cd Update nature.csl (#6117)
891897d fix short title for SBL (#6118)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: c750b6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant