Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry window: Changing selected entry while editing the previous entry #5079

Closed
buhtz opened this issue Jun 27, 2019 · 9 comments
Closed

Entry window: Changing selected entry while editing the previous entry #5079

buhtz opened this issue Jun 27, 2019 · 9 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor groups status: depends-on-external A bug or issue that depends on an update of an external library status: stale

Comments

@buhtz
Copy link

buhtz commented Jun 27, 2019

Current JabRef 5.* dev on Windows 10 64 bit.

Steps to reproduce:

  1. Create group which collect its entry by a keyword (e.g. foobar) and create two entries with such a keyword.
  2. Select that group and double click on one of the entries.
  3. Remove the foobar keyword from that entry.

Now the problem...

  1. The entry disappears from the entry list (because it does not has the keyword for that group anymore).
  2. The second entry is selected then and the entry editor window changes and selects the second entry, too.

Technical this make sense. But for the user it does not.
And it is hazardouse because the user does not recognize that the entry editor window now containts data from another entry.

Imagine a group with 10 entries: My eyes are only on the keywords field in the entry editor! I remove the keyword. The window flickers but the keyword comes back to my eyes (because the next entry is selected automaticly). I think there is a bug (because it is the dev version and the buggy JavaFX-GUI with non-standard-behaviour) and try again, and again, and again... So I removed multiple entries from that group without recognizing it.

What I (as a user) would expect:

  • The entry editor window still contains the first (by me) selected entry. No matter if the entry is still in the entry list or not.
  • Or the entry editor window is closed automaticly when its entry disappears from the current entry list.

Could be relevant for #4564

@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs entry-editor labels Jun 27, 2019
@tobiasdiez tobiasdiez added this to Needs triage in Bugs via automation Jun 27, 2019
@AEgit
Copy link

AEgit commented Jun 27, 2019

Note, that the behaviour in JabRef 3.8.2 was your first expectation, i. e.:

The entry editor window still contains the first (by me) selected entry. No matter if the entry is still in the entry list or not.

When the entry editor was closed, the entry you had worked on was still selected in the main table.

Users coming from older versions might have these expectations.

@buhtz
Copy link
Author

buhtz commented Jun 28, 2019

What you talk about is a closed editor window. But this issue is about open ones.

@AEgit
Copy link

AEgit commented Jun 28, 2019

The first part of my comment talks about an open editor window, namely this part:

Note, that the behaviour in JabRef 3.8.2 was your first expectation, i. e.:

The entry editor window still contains the first (by me) selected entry. No matter if the entry is still in the entry list or not.

The second part talks about what was the case in 3.8.2 when the editor was closed (after being open, i. e. this is not about the editor being closed all the time), namely:

When the entry editor was closed, the entry you had worked on was still selected in the main table.

I think both parts of the comment are relevant for the topic.

@tobiasdiez tobiasdiez moved this from Needs triage to High priority in Bugs Aug 25, 2019
@tobiasdiez tobiasdiez added this to the v5.0 milestone Sep 27, 2019
@tobiasdiez
Copy link
Member

Sadly there is nothing we can do here as it goes back to java bug: https://bugs.openjdk.java.net/browse/JDK-8087910

@tobiasdiez tobiasdiez added the status: depends-on-external A bug or issue that depends on an update of an external library label Oct 19, 2019
@tobiasdiez tobiasdiez removed this from the v5.0 milestone Oct 19, 2019
@AEgit
Copy link

AEgit commented Oct 19, 2019

Do you think it would be worthwhile to create a workaround for this? The bug report (https://bugs.openjdk.java.net/browse/JDK-8087910) is from 2014 and it does not appear, that someone is working on this.

@tobiasdiez
Copy link
Member

It's an irritating issue and I would really like to fix it. But the bug is deep in their code and I don't see an option to fix it or provide a workaround.

@AEgit
Copy link

AEgit commented Oct 19, 2019

I see, thank you for the explanation. Is there a way to convince them, that this bug is worthwhile being fixed (maybe through reporting the issue directly there)?

@koppor
Copy link
Member

koppor commented Feb 2, 2020

Seems like we have to re-implement JavaFX UI elements. Is this a call for reimplementing parts of the entry editor?

I did not experience the bug, however, I am currently no power groups user of JabRef.

Would it be possible to

a) provide a minimal example including a .bib file and precise steps where to click etc?
b) provide a screen recording showing this bug?

From programmer's side, I would love to see some code pointers so that I can think of resources I can assign to this issue.

github-actions bot pushed a commit that referenced this issue Nov 1, 2020
5c376b8 Create karlstad-universitet-kau-harvard-swedish.csl (#5083)
6a62c24 Create ucl-institute-of-education-harvard.csl (#5084)
4d1bbb0 Update ferdinand-porsche-fern-fachhochschule.csl (#5073)
3a9f494 Update cureus.csl (#5087)
181c0dd Create apa-no.csl (#5059)
651ce48 Some fixes for Advanced Functional Materials (#5080)
4e3297a Acta Zoologica Hungarica: Don't demote nd particles
c659df7 Create medicina-delle-dipendenze-italian-journal-of-the-addictions.csl (#5078)
d243055 Update geografia-fisica-e-dinamica-quaternaria.csl (#5079)
1ee3809 Update mcgill-en.csl (#5076)
949cdc6 Update mcgill-fr.csl (#5075)
ee7d4e1 Create chem-catalysis.csl (#5074)
ec9faec Switch Molecular Therapy to Cell (#5070)
cf6034c Switch Elsevier to their own ad-vancouver (#5072)
78cca13 Updates in research-institute-for-nature-and-forest.csl (#4958)
68b7478 Update journal-of-neolithic-archaeology.csl (#5065)
524ba93 Create offa.csl (#5066)
9713a82 Update associacao-brasileira-de-normas-tecnicas-ufrgs-note-initials-with-ibid (#5067)
44449df Uodate associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (#5061)
baf9efa Create İstanbul Üniversitesi Sosyal Bilimler Enstitüsü Ali Ekber Çına… (#5064)
c5c3531 Fix CORR
853a804 Major Update mcgill-fr.csl to 9th ed. (#5057)
d3e2cd9 Update mcgill-en.csl (#5056)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 5c376b8
github-actions bot pushed a commit to dimitra-karadima/jabref that referenced this issue Nov 15, 2020
55200d0 Create computational-intelligence.csl (JabRef#5102)
6d2efc3 Merge branch 'master' of github.com:citation-style-language/styles
60ab0fb Add Steinbeis SMI
d5e0130 Add AAQR Style
d964f9b Create bitonline-publikationen.csl (JabRef#5090)
0dc1a56 Add "APA 7th edition" to Norsk APA style titles (JabRef#5098)
3b6aaf7 Update norsk-apa-manual.csl (JabRef#5095)
0139c63 Create technische-universitat-dresden-betriebswirtschaftslehre-rechnungswesen-controlling.csl (JabRef#5034)
fdc4497 Update universidade-estadual-de-alagoas-abnt (JabRef#5085)
afdc2ea Create revista-espanola-de-nutricion-humana-y-dietetica.csl (JabRef#5082)
939189d Create citation-compass-apa-note-no.csl (JabRef#5060)
414f5e6  brazilian-journal-of-veterinary-research: add bib sorting (JabRef#5091)
dbae9d7 Add DOI to Thieme German
f4399aa APA: match="any" bugfixes (JabRef#5092)
d0cc2c4 Add APA numeric and update BioEssays (JabRef#5089)
5c376b8 Create karlstad-universitet-kau-harvard-swedish.csl (JabRef#5083)
6a62c24 Create ucl-institute-of-education-harvard.csl (JabRef#5084)
4d1bbb0 Update ferdinand-porsche-fern-fachhochschule.csl (JabRef#5073)
3a9f494 Update cureus.csl (JabRef#5087)
181c0dd Create apa-no.csl (JabRef#5059)
651ce48 Some fixes for Advanced Functional Materials (JabRef#5080)
4e3297a Acta Zoologica Hungarica: Don't demote nd particles
c659df7 Create medicina-delle-dipendenze-italian-journal-of-the-addictions.csl (JabRef#5078)
d243055 Update geografia-fisica-e-dinamica-quaternaria.csl (JabRef#5079)
1ee3809 Update mcgill-en.csl (JabRef#5076)
949cdc6 Update mcgill-fr.csl (JabRef#5075)
ee7d4e1 Create chem-catalysis.csl (JabRef#5074)
ec9faec Switch Molecular Therapy to Cell (JabRef#5070)
cf6034c Switch Elsevier to their own ad-vancouver (JabRef#5072)
78cca13 Updates in research-institute-for-nature-and-forest.csl (JabRef#4958)
68b7478 Update journal-of-neolithic-archaeology.csl (JabRef#5065)
524ba93 Create offa.csl (JabRef#5066)
9713a82 Update associacao-brasileira-de-normas-tecnicas-ufrgs-note-initials-with-ibid (JabRef#5067)
44449df Uodate associacao-brasileira-de-normas-tecnicas-ufrgs-initials.csl (JabRef#5061)
baf9efa Create İstanbul Üniversitesi Sosyal Bilimler Enstitüsü Ali Ekber Çına… (JabRef#5064)
c5c3531 Fix CORR
853a804 Major Update mcgill-fr.csl to 9th ed. (JabRef#5057)
d3e2cd9 Update mcgill-en.csl (JabRef#5056)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 55200d0
@github-actions
Copy link
Contributor

This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs.

As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:

  • If there has been a longer discussion, add a short summary of the most important points as a new comment (if not yet existing).
  • Provide further steps or information on how to reproduce this issue.
  • Upvote the initial post if you like to see it implemented soon. Votes are not the only metric that we use to determine the requests that are implemented, however, they do factor into our decision-making process.
  • If all information is provided and still up-to-date, then just add a short comment that the issue is still relevant.

Thank you for your contribution!

@github-actions github-actions bot closed this as completed Jan 6, 2021
Bugs automation moved this from High priority to Closed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor groups status: depends-on-external A bug or issue that depends on an update of an external library status: stale
Projects
Archived in project
Development

No branches or pull requests

5 participants