Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dpms action #341

Closed
wants to merge 1 commit into from
Closed

fix dpms action #341

wants to merge 1 commit into from

Conversation

tonyho
Copy link

@tonyho tonyho commented Jun 14, 2024

Pull Request

Description

Please read these instructions and remove unnecessary text.

  • Try to include a summary of the changes and which issue is fixed.
  • Also include relevant motivation and context (if applicable).
  • List any dependencies that are required for this change. (e.g., packages or other PRs)
  • Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue)
  • Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable)

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I want to add something in Hyprland-Dots wiki.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

(if appropriate)

Additional context

Add any other context about the problem here.

@JaKooLit
Copy link
Owner

kindly complete all thw information needed

@ThaSiouL
Copy link
Contributor

ThaSiouL commented Jun 14, 2024

Wait why do you want to turn the monitor off after waking up from sleep?
Have you tested this?

@tonyho
Copy link
Author

tonyho commented Jun 17, 2024

kindly complete all thw information needed↳

Now I fullfill the infomation. But the commit messge format, I thinks it can be changed when merging.

@JaKooLit
Copy link
Owner

kindly complete all thw information needed↳

Now I fullfill the infomation. But the commit messge format, I thinks it can be changed when merging.

#341 (comment)

pls answer his question

@tonyho
Copy link
Author

tonyho commented Jun 17, 2024

Wait why do you want to turn the monitor off after waking up from sleep? Have you tested this?↳

Yes, I tested it locally.

Plus, for the on/off on ' hyprctl dispatch dpms on ', I tested directly on terminal
hyprctl dispatch dpms off: will turn off all my monitors

@ThaSiouL
Copy link
Contributor

But why do you want to turn off the monitor after waking the PC up from sleep?
What's the use case for that?

@JaKooLit
Copy link
Owner

Since you didnt answer @ThaSiouL question, I am squashing this PR

@JaKooLit JaKooLit closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants