forked from ruanyf/es6tutorial
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
学习pull request #1
Open
JS-mark
wants to merge
783
commits into
JS-mark:gh-pages
Choose a base branch
from
ruanyf:gh-pages
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修改了两处: 1)步骤描述 `ReturnIfAbrupt(result)` 应该描述为: > 1. If result is an abrupt completion, return result. > 2. Set result to result.[[Value]] 而非 > 1. If resultCompletionRecord is an abrupt completion, return resultCompletionRecord. > 2. Let result be resultCompletionRecord.[[Value]]. 改写之后,方便简写前后的对照,而不至于对不上号。 另外,第一步也修改为:Let result be AbstractOp() “Set result to result.[[Value]]”的写法参考了这里的:https://v8.dev/blog/understanding-ecmascript-part-1#completion-records 2) 简化了步骤之后的文字描述
统一“抽象操作的运行流程”的描述
Executing file directly must start with (absolute/relative) path under Linux
fix(proposals): shell exec style
lowercase "readfile"
Update module.md
``` Reflect.ownKeys(target) Returns an array of the target object's own (not inherited) property keys. ``` Refrence: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect
docs:完善Reflect.ownkeys()方法的描述
docs(set-map): WeakSet methods
docs(generator): update example
Update regex.md
fix: 内容修正
Update module-loader.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.