Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

ModifyOrderByClientOrderIdAsync should take a string for clientOrderId #31

Open
kevindarby opened this issue Aug 10, 2022 · 0 comments
Open

Comments

@kevindarby
Copy link

Describe the bug
I believe the IFTXClientTradeApiTrading.ModifyOrderByClientOrderIdAsync interface and impl should take a string for clientOrderId (the first argument)

To Reproduce
See here:

Task<WebCallResult<FTXOrder>> ModifyOrderByClientOrderIdAsync(long clientOrderId, decimal? price = null, decimal? quantity = null, string? newClientOrderId = null, string? subaccountName = null, CancellationToken ct = default);

clientOrderId is declared as a long

Expected behavior
clientOrderId is a string in the cancel and place methods, so it should probably be a string here.

kevindarby added a commit to lurium/FTX.Net that referenced this issue Aug 12, 2022
ModifyOrderByClientOrderIdAsync should take a string clientOrderId
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant