Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpa pyecsca #44

Merged
merged 8 commits into from
Oct 10, 2023
Merged

Cpa pyecsca #44

merged 8 commits into from
Oct 10, 2023

Conversation

andrr3j
Copy link
Contributor

@andrr3j andrr3j commented Oct 5, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #44 (79ec70d) into master (0e300b7) will decrease coverage by 0.94%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   84.57%   83.62%   -0.94%     
==========================================
  Files          72       73       +1     
  Lines        5644     5708      +64     
  Branches     1045     1056      +11     
==========================================
  Hits         4773     4773              
- Misses        657      721      +64     
  Partials      214      214              
Files Coverage Δ
pyecsca/sca/target/emulator.py 0.00% <0.00%> (ø)
pyecsca/sca/attack/CPA.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@J08nY
Copy link
Owner

J08nY commented Oct 5, 2023

pyecsca/sca/attack/CPA.py:30: error: Incompatible types in assignment (expression has type "ndarray[Any, dtype[Any]]", variable has type "list[Trace]")  [assignment]
pyecsca/sca/attack/CPA.py:56: error: Incompatible return value type (got "list[Any]", expected "ndarray[Any, dtype[Any]]")  [return-value]

Copy link
Owner

@J08nY J08nY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change

pyecsca/sca/attack/CPA.py Outdated Show resolved Hide resolved
@J08nY
Copy link
Owner

J08nY commented Oct 5, 2023

Also please fix the issues found by the codestyle check.

@J08nY J08nY added this to In progress in Attack implementations Oct 5, 2023
@J08nY J08nY merged commit fdab7fb into J08nY:master Oct 10, 2023
13 of 15 checks passed
@J08nY J08nY moved this from In progress to Done in Attack implementations Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants