Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Fix the trigger "auto-drop" function (the trigger drop needs to be … #215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darkag
Copy link

@darkag darkag commented Oct 16, 2020

…the last operation before return)

  • Fix incorrect WaitForNotifications start that prevent stop to termitate if stoped on application closing (wrong task was waited)

…the last operation before return)

- Fix incorrect WaitForNotifications start that prevent stop to termitate if stoped on application closing (wrong task was waited)
@SteffeyDev
Copy link

Before making this change, did you experience orphaned triggers in SQL that were causing problems?

@darkag
Copy link
Author

darkag commented Oct 31, 2020

Yes that's why I started to look in the source code. When the problem occured I was not able to update the watched table since the trigger drop command failed.

I got error messages like the ones described in issue #214 or #188.

@SteffeyDev
Copy link

Have you run your version of the code in production for some time without issues? We are seeing the same issues

@darkag
Copy link
Author

darkag commented Nov 2, 2020

Yes, no problems since the corrections I've made.

@lekrus
Copy link

lekrus commented Dec 16, 2020

unfortunately this fix didn't work for me: had issues with stopping listener and also it was not possible to do a restart after an error, something is wrong with changes to WaitForNotifications await

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants