events.lua: Fix bug with unexpected Classes on TBC. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On TBC GetNumClasses() returns 11, but the expansion only has 9 classes. The code goes on to call GetClassInfo() which returns nil for classIndex when it does not exist in the game. i.e 6 - Death Knight, 10 - Monk, etc. It then tries to index RAID_CLASS_COLORS with nil which of course causes an error.
Certain fields in TBC from Enum.UIWidgetVisualizationType and C_UIWidgetManager are nil. Check if the fields are both non, nil before adding them into the _widgetHandlers table. Missing Fields on TBC. C_UIWidgetManager Enum.UIWidgetVisualizationType TextureAndText GetTextureAndTextVisualizationInfo SpellDisplay GetSpellDisplayVisualizationInfo DoubleStateIconRow GetDoubleStateIconRowVisualizationInfo TextureAndTextRow GetTextureAndTextRowVisualizationInfo ZoneControl GetZoneControlVisualizationInfo CaptureZone GetCaptureZoneVisualizationInfo TextureWithAnimation GetTextureWithAnimationVisualizationInfo DiscreteProgressSteps GetDiscreteProgressStepsVisualizationInfo ScenarioHeaderTimer GetScenarioHeaderTimerWidgetVisualizationInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On TBC GetNumClasses() returns 11, but the expansion only has 9
classes. The code goes on to call GetClassInfo() which returns
nil for classIndex when it does not exist in the game.
i.e 6 - Death Knight, 10 - Monk, etc. It then tries
to index RAID_CLASS_COLORS with nil which of course causes an error.