Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add segmented control to filter results by Size or Alphabetically #13

Merged
merged 2 commits into from
Oct 31, 2020

Conversation

iMokhles
Copy link
Contributor

Here's how it looks like ( it's my first SwiftUI code ever )
Dumbledore: after all this time
Me: YES ;)

Capture d’écran 2020-10-29 à 12 16 40

Capture d’écran 2020-10-29 à 12 19 49

@IrelDev IrelDev changed the title added segmented control to filter results by Size or Alphabetically Add segmented control to filter results by Size or Alphabetically Oct 29, 2020
@IrelDev
Copy link
Owner

IrelDev commented Oct 29, 2020

Thank you for your pull request!
Firstly, I think that it should be "Filter by" or "Filtered by" instead of "Filter option" and "Name" instead of "Alphabetical".

Secondly, segmented control is too large and I recommend to put Spacer() between text and segmented control.

Finally why does the directory list view look like it has a container with right & bottom borders?

@iMokhles
Copy link
Contributor Author

List view look like it has a container with right & bottom borders?

i don't really know

@IrelDev IrelDev merged commit 78e0844 into IrelDev:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants