Upload polish #109
Merged
Upload polish #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion` if specified. I think this part just got missed in Ionaru#106. I'm not sure if I should be doing anything with the `onSuccess` and `onError` callbacks here.
Without this change, if you either: - Click and drag some text into the markdown editor, or - Copy paste some text into the markdown editor The status bar will get updated to say "Uploading image ...", and will never stop.
jfly
added a commit
to jfly/worldcubeassociation.org
that referenced
this pull request
Jul 29, 2019
Support for uploading images was very recently added to EasyMDE. I followed https://medium.com/weareevermore/manual-uploads-using-activestorage-47808dab1b65 to build a new endpoint just for uploading images, and then wrote a little bit of javascript to actually connect EasyMDE to this new endpoint. This is part of thewca#4309. NOTE: We should not merge this up until Ionaru/easy-markdown-editor#109 is merged and released. Then we should update this diff to pull in latest version of EasyMDE with these fixes.
jfly
added a commit
to jfly/worldcubeassociation.org
that referenced
this pull request
Jul 29, 2019
Support for uploading images was very recently added to EasyMDE. I followed https://medium.com/weareevermore/manual-uploads-using-activestorage-47808dab1b65 to build a new endpoint just for uploading images, and then wrote a little bit of javascript to actually connect EasyMDE to this new endpoint. This is part of thewca#4309. NOTE: We should not merge this up until Ionaru/easy-markdown-editor#109 is merged and released. Then we should update this diff to pull in latest version of EasyMDE with these fixes.
jfly
added a commit
to jfly/worldcubeassociation.org
that referenced
this pull request
Jul 29, 2019
Support for uploading images was very recently added to EasyMDE. I followed https://medium.com/weareevermore/manual-uploads-using-activestorage-47808dab1b65 to build a new endpoint just for uploading images, and then wrote a little bit of javascript to actually connect EasyMDE to this new endpoint. This is part of thewca#4309. NOTE: We should not merge this up until Ionaru/easy-markdown-editor#109 is merged and released. Then we should update this diff to pull in latest version of EasyMDE with these fixes.
jfly
added a commit
to jfly/worldcubeassociation.org
that referenced
this pull request
Jul 29, 2019
Support for uploading images was very recently added to EasyMDE. I followed https://medium.com/weareevermore/manual-uploads-using-activestorage-47808dab1b65 to build a new endpoint just for uploading images, and then wrote a little bit of javascript to actually connect EasyMDE to this new endpoint. This is part of thewca#4309. NOTE: We should not merge this up until Ionaru/easy-markdown-editor#109 is merged and released. Then we should update this diff to pull in latest version of EasyMDE with these fixes.
jfly
added a commit
to jfly/worldcubeassociation.org
that referenced
this pull request
Jul 30, 2019
Support for uploading images was very recently added to EasyMDE. I followed https://medium.com/weareevermore/manual-uploads-using-activestorage-47808dab1b65 to build a new endpoint just for uploading images, and then wrote a little bit of javascript to actually connect EasyMDE to this new endpoint. This is part of thewca#4309. NOTE: We should not merge this up until Ionaru/easy-markdown-editor#109 is merged and released. Then we should update this diff to pull in latest version of EasyMDE with these fixes.
jfly
added a commit
to jfly/worldcubeassociation.org
that referenced
this pull request
Jul 30, 2019
Support for uploading images was very recently added to EasyMDE. I followed https://medium.com/weareevermore/manual-uploads-using-activestorage-47808dab1b65 to build a new endpoint just for uploading images, and then wrote a little bit of javascript to actually connect EasyMDE to this new endpoint. Unfortunately, I couldn't find a good way to add validations to this new endpoint. Since we only allow fairly trusted users to access this endpoint, I think that's acceptable for now, but eventually it would be nice to validate file size/format/etc. See thewca#4380 for more information. This is part of thewca#4309. NOTE: We should not merge this up until Ionaru/easy-markdown-editor#109 is merged and released. Then we should update this diff to pull in latest version of EasyMDE with these fixes.
jfly
added a commit
to jfly/worldcubeassociation.org
that referenced
this pull request
Jul 31, 2019
Support for uploading images was very recently added to EasyMDE. I followed https://medium.com/weareevermore/manual-uploads-using-activestorage-47808dab1b65 to build a new endpoint just for uploading images, and then wrote a little bit of javascript to actually connect EasyMDE to this new endpoint. Unfortunately, I couldn't find a good way to add validations to this new endpoint. Since we only allow fairly trusted users to access this endpoint, I think that's acceptable for now, but eventually it would be nice to validate file size/format/etc. See thewca#4380 for more information. This is part of thewca#4309. NOTE: We should not merge this up until Ionaru/easy-markdown-editor#109 is merged and released. Then we should update this diff to pull in latest version of EasyMDE with these fixes.
jfly
added a commit
to jfly/worldcubeassociation.org
that referenced
this pull request
Jul 31, 2019
Support for uploading images was very recently added to EasyMDE. I followed https://medium.com/weareevermore/manual-uploads-using-activestorage-47808dab1b65 to build a new endpoint just for uploading images, and then wrote a little bit of javascript to actually connect EasyMDE to this new endpoint. Unfortunately, I couldn't find a good way to add validations to this new endpoint. Since we only allow fairly trusted users to access this endpoint, I think that's acceptable for now, but eventually it would be nice to validate file size/format/etc. See thewca#4380 for more information. This is part of thewca#4309. I found a problem with EasyMDE's image upload button: it doesn't seem to use the custom image upload function if you've specified one. It was fairly easy to work around this issue, but I have filed Ionaru/easy-markdown-editor#109 upstream to fix the bug in the right place.
jfly
added a commit
to thewca/worldcubeassociation.org
that referenced
this pull request
Jul 31, 2019
Support for uploading images was very recently added to EasyMDE. I followed https://medium.com/weareevermore/manual-uploads-using-activestorage-47808dab1b65 to build a new endpoint just for uploading images, and then wrote a little bit of javascript to actually connect EasyMDE to this new endpoint. Unfortunately, I couldn't find a good way to add validations to this new endpoint. Since we only allow fairly trusted users to access this endpoint, I think that's acceptable for now, but eventually it would be nice to validate file size/format/etc. See #4380 for more information. This is part of #4309. I found a problem with EasyMDE's image upload button: it doesn't seem to use the custom image upload function if you've specified one. It was fairly easy to work around this issue, but I have filed Ionaru/easy-markdown-editor#109 upstream to fix the bug in the right place.
|
I apologise for the extremely late reaction. Your change looks good, I'll update the changelog and merge it into master. |
Ionaru
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues I found while playing around with the awesome new file upload support:
options.imageUploadFunctionif specified.