Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would be great to get some information about this fork #1

Closed
copernicus365 opened this issue Jan 4, 2018 · 8 comments
Closed

Would be great to get some information about this fork #1

copernicus365 opened this issue Jan 4, 2018 · 8 comments
Assignees
Labels

Comments

@copernicus365
Copy link

Hi there, looks like you've been adding some good stuff to simplemde, while the main simplemde project hasn't been updated for 2 years (unless I'm reading it wrong). Any chance you could post some information about this fork? Thanks

@Ionaru
Copy link
Owner

Ionaru commented Jan 4, 2018

The has been some activity on the develop branch, but that was more than half a year ago.

I'd be happy to post some info, what would you like to know?

@Ionaru Ionaru added the Question label Jan 4, 2018
@Ionaru Ionaru self-assigned this Jan 4, 2018
@copernicus365
Copy link
Author

Thanks for the reply. I found your fork by browsing thru this page (https://github.com/sparksuite/simplemde-markdown-editor/network), and checking out some of those forks. I certainly could be missing a major one, but your commits seem to be the only fork I've seen thus far that is actually a general purpose improvement of the library, rather than just being minor little changes, or idiosyncratic ones (not general purpose). Would you say that is true? And is there a rhyme or reason to the changes you are making?

I see your commits are still under a development branch, but just wondering if you would give a thumbs up (no warranty included of course 😉) that you think your fork is an overall bettered version, which people might want to therefore consider using instead.

@Ionaru
Copy link
Owner

Ionaru commented Jan 4, 2018

I started this fork originally to put FA5 support in via pull-request, I needed that for a project I was working on. My plan now is to make this version of simplemde better than the original, and continue development on it. So yeah I'd say it's a general purpose improvement.

So far I've just been fixing things that were bugging me personally, I haven't had the time to go over all the code but there are some other improvements I want to make. One of them is the isMobile() function because holy crap what even is that?!

From what I've seen of the current development branch, I think it's better than the current simplemde version on NPM, yes. But keep in mind that I didn't do any extensive testing on it.

@copernicus365
Copy link
Author

Terrific! I'm already testing out your fork and it's working great thus far. Thanks for your work.

"One of them is the isMobile() function because holy crap what even is that?!"
😆
"FA5" ?

@Ionaru
Copy link
Owner

Ionaru commented Jan 4, 2018

FA5 == FontAwesome 5

@MayMeow
Copy link

MayMeow commented Mar 3, 2018

Hi. This fork will be available to install via npm?

@Ionaru
Copy link
Owner

Ionaru commented Mar 4, 2018

Yes I do plan to release this version of SimpleMDE on NPM, but there are a few things I want to do first. One is to come up with a new name for the project, because simplemde is already taken, also I want to edit the README a bit, simplify it and set up a demo site for the project.

@Ionaru
Copy link
Owner

Ionaru commented Apr 25, 2018

Closing this, EasyMDE is now released on NPM! 🎉

@Ionaru Ionaru closed this as completed Apr 25, 2018
Ionaru pushed a commit that referenced this issue Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants