Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous stream frequency diagnostics #1471

Merged

Conversation

kubja
Copy link

@kubja kubja commented Oct 28, 2020

  • This pull request modifies frequency diagnostics to run independently from the frame callbacks. In the current implementation, frequency is updated with frame callback when nodes were subscribed. The asynchronous setup is more suitable for sensor health monitoring and enables to detect that there is a connection issue even when no node is subscribed. The argument was also made in issue Frequency diagnostics not published until getNumSubscribers > 0 #1417 .
  • The diagnostics messages for each stream are published alongside the temperature diagnostics update. The loop update rate was lowered from 10s to 1s.
  • The function was tested with Intel Realsense D435i.

@mikepurvis
Copy link
Contributor

Looks awesome! Thanks for taking a stab at this; your change also looks a lot simpler than what I was picturing, so that's great.

@doronhi doronhi merged commit 30708b5 into IntelRealSense:development Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants