Parser Cleanup #126

barrh · 2019-01-13T22:21:12Z

Move parser to its own file
Enhance API to support more activation logging options
Case-insensitive arguments

Enable logging activation both durning training and validation at the same session.

* Parser is moved from compress_classifier into its own file. * Torch version check is moved to precede main() call. * Move main definition to the top of the file.

nzmora

These changes look fine.
@guyjacob - please weigh-in regarding the timing, since you want to do a large merge of your branch.

guyjacob · 2019-01-15T08:35:16Z

It's not a big deal from my side. We can merge this now. Thanks @barrh

nzmora · 2019-01-15T12:06:44Z

Hey @barrh ,
Did you test this code?
See distiller/tests:

$ cd distiller/tests
$ pytest
$ python3 full_flow_tests.py

Thanks
Neta

barrh · 2019-01-15T12:26:54Z

Just did - failed miserably in my environment.
Note that I do not confirm with Distiller's strict requirements.

nzmora · 2019-01-16T19:04:39Z

All test are successful on my machine. I'll merge shortly.

* Support for multi-phase activations logging Enable logging activation both durning training and validation at the same session. * Refactoring: Move parser to its own file * Parser is moved from compress_classifier into its own file. * Torch version check is moved to precede main() call. * Move main definition to the top of the file. * Modify parser choices to case-insensitive

barrh added 3 commits January 14, 2019 12:06

Support for multi-phase activations logging

cbc1fff

Enable logging activation both durning training and validation at the same session.

Cleanup: Move parser to its own file

9a1e28a

* Parser is moved from compress_classifier into its own file. * Torch version check is moved to precede main() call. * Move main definition to the top of the file.

Modify parser choices to case-insensitive

0c42a48

barrh force-pushed the parser_update branch from 2b1c4af to 0c42a48 Compare January 14, 2019 10:11

nzmora reviewed Jan 14, 2019

View reviewed changes

nzmora merged commit cfbc379 into IntelLabs:master Jan 16, 2019

barrh deleted the parser_update branch January 20, 2019 13:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parser Cleanup #126

Parser Cleanup #126

barrh commented Jan 13, 2019

nzmora left a comment

guyjacob commented Jan 15, 2019

nzmora commented Jan 15, 2019

barrh commented Jan 15, 2019

nzmora commented Jan 16, 2019

Parser Cleanup #126

Parser Cleanup #126

Conversation

barrh commented Jan 13, 2019

nzmora left a comment

Choose a reason for hiding this comment

guyjacob commented Jan 15, 2019

nzmora commented Jan 15, 2019

barrh commented Jan 15, 2019

nzmora commented Jan 16, 2019