Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when rendering headerless table #279

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Fix crash when rendering headerless table #279

merged 1 commit into from
Mar 20, 2024

Conversation

CosmicHorrorDev
Copy link
Collaborator

@CosmicHorrorDev CosmicHorrorDev commented Mar 20, 2024 •
edited
Loading

Fixes #261

<table>
  <tr>
    <td>one</td>
    <td>two</td>
  </tr>
  <tr>
    <td>three</td>
    <td>four</td>
  </tr>
</table>

renders as

image

@CosmicHorrorDev CosmicHorrorDev added C-bug Category: Something isn't working A-table Area: Dealing with markdown tables labels Mar 20, 2024
@CosmicHorrorDev CosmicHorrorDev merged commit 51ec308 into Inlyne-Project:main Mar 20, 2024
9 checks passed
CosmicHorrorDev added a commit to CosmicHorrorDev/inlyne that referenced this pull request Apr 6, 2024
@CosmicHorrorDev
fix(table): Fix crash when rendering headerless table (Inlyne-Project…
d4f09f5 
…#279)
CosmicHorrorDev added a commit that referenced this pull request Apr 6, 2024
@CosmicHorrorDev @0x61nas @kokoISnoTarget
v0.4.2 backportapalooza (#303)
744815f 
* fix(links): ignore the case when look-up for an anchor (#256)

* Fix exclude for `manual_test_data` (#257)

* docs(repology): Exclude unsupported package repos (#271)

* fix(table): Fix crash when rendering headerless table (#279)

* docs(readme): Improve installation docs (#280)

* fix: add check to render_selection, so it does not return small boxes. (#288)

Signed-off-by: konrad <[email protected]>

* chore(deps): Update `smithay-client-toolkit` from v0.16.0 -> v0.16.1 (#298)

* chore: Dont check for typos on test data

---------

Signed-off-by: konrad <[email protected]>
Co-authored-by: Anas <[email protected]>
Co-authored-by: kokoISnoTarget <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-table Area: Dealing with markdown tables C-bug Category: Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tables not containing table header panic
1 participant
@CosmicHorrorDev