update verilator coverage to work if vl_finish ends the testrun (coco…

…tb#3217) Remove vl_finish() from verilator.cpp to help make verilator coverage work more consistently verified by adding '--coverage' to Makefile.verilator variable EXTRA_ARGS and then running cocotb/tests/tests_1279. Pre verilator.cpp change, no coverage.dat is generated. Post change, one is generated. --------- Co-authored-by: David Stanford <[email protected]> Co-authored-by: Marlon James <[email protected]>
Ingrimmel · Feb 9, 2023 · 1fbf441 · 1fbf441
1 parent 519963a
commit 1fbf441
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/cocotb/share/lib/verilator/verilator.cpp b/cocotb/share/lib/verilator/verilator.cpp
@@ -115,7 +115,6 @@ int main(int argc, char** argv) {
  // If there are no more cbAfterDelay callbacks,
  // the next deadline is max value, so end the simulation now
  if (next_time == static_cast<vluint64_t>(~0ULL)) {
- vl_finish(__FILE__, __LINE__, "");
  break;
  } else {
  main_time = next_time;

diff --git a/documentation/source/newsfragments/1478.bugfix.rst b/documentation/source/newsfragments/1478.bugfix.rst
@@ -0,0 +1 @@
+Fixed Verilator not writing coverage files in some cases.