Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for fr language 🌎🇫🇷 #210

Merged
merged 23 commits into from
Jan 13, 2023
Merged

feat: adding support for fr language 🌎🇫🇷 #210

merged 23 commits into from
Jan 13, 2023

Conversation

Grraahaam
Copy link
Contributor

@Grraahaam Grraahaam commented Jan 11, 2023

Description 📣

Adding support for fr language.

This pull request refers to this issue : #181 (Help us translate Infisical)

I had to change some frontend code as well to make the changes work as expected, I'm not an expert so please take a look ✌️

👀 - looking for help, ✔️ - ready, ⚠️ - in progress

Files Status
activity ✔️
billing ✔️
commom ✔️
dashboard ✔️
integrations ✔️
login ✔️
nav ✔️
section-incident ✔️
section-members ✔️
section-password ✔️
section-token ✔️
settings-members ✔️
settings-org ✔️
settings-personal ✔️
settings-project ✔️
signup ✔️

inspired by #199

Concerns

I'm wondering about the below meanings :

// frontend/public/locales/en/section-members.json
"org-members-description": "...These users could afterwards be formed into projects.",

// frontend/public/locales/en/settings-org.json
"description": "...These users could afterwards be formed into projects."

How could users be "formed into projects"? IMO the wording isn't pretty clear in that case

Moreover, by testing the changes I've made with the latest version I had, some translation don't seem to be applied... AFAIK it seems to be related to the next-i18n namespace concept : https://www.i18next.com/principles/namespaces (Edit: seems to be fixed now with the latest Infisical commits)

But there's still some hard-coded text at some places, I guess it'll be fixed with time ✌️

Tests 🛠️

Follow the development setup to test it locally : https://infisical.com/docs/contributing/developing

# Build and launch the Infisical app
make up-dev

# Reach to your web browser and type
https://localhost:8080

# Change language to `fr`
# Dropdown list in the top right corner, and let the fun begin

Copy link
Collaborator

@vmatsiiako vmatsiiako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much once again @Grraahaam! This is amazing!

@vmatsiiako vmatsiiako merged commit dc76be3 into Infisical:main Jan 13, 2023
@Grraahaam Grraahaam deleted the feat/translation-fr branch January 13, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants