Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvised secret input component and fontawesome performance improvment #1818

Merged
merged 5 commits into from
May 13, 2024
Merged

Improvised secret input component and fontawesome performance improvment #1818

merged 5 commits into from
May 13, 2024

Conversation

akhilmhdh
Copy link
Member

Description 📣

  1. Fixed rendering issue caused by the auto completion over secret input
  2. Simplified the InfisicalSecretInput
  3. Font awesome icons optimization by SVG Symbols to improve rendering time
  4. Fixed redirect issue in dashboard
  5. Fixed unique key error for secret input

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@akhilmhdh akhilmhdh self-assigned this May 13, 2024
maidul98
maidul98 approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maidul98 maidul98 merged commit c176d1e into Infisical:main May 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maidul98 maidul98 maidul98 approved these changes

@sheensantoscapadngan sheensantoscapadngan Awaiting requested review from sheensantoscapadngan

Assignees

@akhilmhdh akhilmhdh

Labels
👀 frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akhilmhdh @maidul98