Disable TLS renegotiation, bump Windows deps and fix Icinga DB crashes #9945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API doesn't need it and a customer's security scanner is afraid of a potential DoS attack vector.
Note: For doc/21-development.md use:
perl -pi -e 's/(boost[-\w]*?1[-_]?)82/${1}83/g' doc/21-development.md
icinga-probot
bot
added
area/api
yhabteab
requested changes
Dec 20, 2023
| @@ -1851,7 +1854,6 @@ void IcingaDB::SendStartedDowntime(const Downtime::Ptr& downtime) | |||
| "flexible_duration", Convert::ToString(TimestampToMilliseconds(std::max(0.0, downtime->GetDuration()))), | |||
| "scheduled_start_time", Convert::ToString(TimestampToMilliseconds(downtime->GetStartTime())), | |||
| "scheduled_end_time", Convert::ToString(TimestampToMilliseconds(downtime->GetEndTime())), | |||
| "has_been_cancelled", Convert::ToString((unsigned short)downtime->GetWasCancelled()), | |||
There was a problem hiding this comment.
Looks like you have cherry-picked the wrong version of #9896.
…led may be 1 The table sla_history_downtime requires a downtime_end. The Go daemon takes the cancel_time if has_been_cancelled is 1. So we must supply a cancel_time whereever has_been_cancelled is 1. Otherwise the Go daemon can't process some entries.
Al2Klimov
force-pushed
the
2139backport
branch
from
dee132b
to
b2d975f
Compare
yhabteab
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of