IcingaDB::PrepareObject(): round Notification#times.{begin,end} not to crash Go daemon #9794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabteab
previously approved these changes
Jun 20, 2023
|
Note: Would be nice if you'd also provide an After test cases. |
|
After, i.e. with the PR, nothing special happens in contrast to before. |
julianbrost
reviewed
Jun 26, 2023
Al2Klimov
force-pushed
the
round-notification-times-begin-end-not-to-crash-go-daemon
branch
from
c91dcf6
to
992e412
Compare
julianbrost
requested changes
Jun 27, 2023
…o crash Go daemon The latter expects ints, not floats - not to mention strings. Luckily Icinga already enforces numeric strings so that we can cast it to number.
….{begin,end} not to crash Go daemon
At least our PostgreSQL schema enforces positive values.
Al2Klimov
force-pushed
the
round-notification-times-begin-end-not-to-crash-go-daemon
branch
from
992e412
to
dccb678
Compare
julianbrost
approved these changes
Jun 27, 2023
icinga-probot
bot
deleted the
round-notification-times-begin-end-not-to-crash-go-daemon
branch
Al2Klimov
added a commit
that referenced
this pull request
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter expects ints, not floats - not to mention strings. Luckily Icinga already enforces numeric strings so that we can cast it to number.
refs #9793
Test case
Standard config plus:
Before
-42.5
2023-06-20T10:25:23.821+0200 FATAL icingadb json: cannot unmarshal number -42.5 into Go value of type int64"-42.5"
2023-06-20T10:26:25.967+0200 FATAL icingadb json: cannot unmarshal string into Go value of type int64