Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_icmp: double packet loss thresholds #9041

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Conversation

Al2Klimov
Copy link
Member

... to get not instantly critical after 1 packet lost (20%), but after 2.

fixes #8606

@Al2Klimov Al2Klimov added this to the 2.14.0 milestone Oct 19, 2021
@cla-bot cla-bot bot added the cla/signed label Oct 19, 2021
@Al2Klimov
Copy link
Member Author

Sorry, colleagues, but fixing this absolutely trivial one is ways faster that even talking about.

Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also has to be adapted in the docs and the description string above (the latter ones are outdated (or maybe just wrong forever) already).

@Al2Klimov
Copy link
Member Author

Why? 1 packet of 5 is 20%.

@julianbrost
Copy link
Contributor

julianbrost commented Jan 16, 2023

But it says 40% and 80% at the moment (and the timeouts are also wrong):

"-w" = {
value = "$icmp_wrta$,$icmp_wpl$%"
description = "warning threshold (currently 200.000ms,40%)"
}
"-c" = {
value = "$icmp_crta$,$icmp_cpl$%"
description = "critical threshold (currently 500.000ms,80%)"
}

description string != PR description

@Al2Klimov
Copy link
Member Author

Ah! This description string above...

... to get not instantly critical after 1 packet lost (20%), but after 2.
@julianbrost julianbrost merged commit ce5e6e7 into master Jan 17, 2023
@icinga-probot icinga-probot bot deleted the Al2Klimov-patch-1 branch January 17, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checkCommand icmp settings not plausible
2 participants