Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Describe parameter 'expiry' in 'add-comment' API action #8943

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Docs: Describe parameter 'expiry' in 'add-comment' API action #8943

merged 1 commit into from
Jul 30, 2021

Conversation

N-o-X
Copy link
Contributor

@N-o-X N-o-X commented Jul 29, 2021

Add missing parameter description for #8035

@N-o-X N-o-X added bug Something isn't working area/documentation End-user or developer help labels Jul 29, 2021
@N-o-X N-o-X added this to the 2.13.0 milestone Jul 29, 2021
@N-o-X N-o-X requested a review from Al2Klimov July 29, 2021 15:58
@icinga-probot icinga-probot bot added area/api REST API enhancement New feature or request labels Jul 29, 2021
Al2Klimov
Al2Klimov requested changes Jul 29, 2021
View reviewed changes
Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you adjusted the table. Bad that only partially. (files changed / hide whitespace)

@N-o-X N-o-X force-pushed the bugfix/api-add-comment-expiry-docs branch from cde2ba2 to 3bc90e8 Compare July 29, 2021 16:03
@N-o-X N-o-X requested a review from Al2Klimov July 29, 2021 16:04
@julianbrost julianbrost merged commit 4c90709 into master Jul 30, 2021
@icinga-probot icinga-probot bot deleted the bugfix/api-add-comment-expiry-docs branch July 30, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Al2Klimov Al2Klimov Al2Klimov approved these changes

Assignees
No one assigned
Labels
area/api REST API area/documentation End-user or developer help bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@N-o-X @Al2Klimov @julianbrost