RedisConnection: copy callback before calling it #8940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the callback to call RedisConnection::SetConnectedCallback() to set another callback for this connection. This sets m_ConnectedCallback and thereby destroys the std::function while it's running resulting in undefined behavior. By operating on a copy, m_ConnectedCallback can be set without affecting the currently running callback.
N-o-X
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the callback to call RedisConnection::SetConnectedCallback() to set another callback for this connection. This sets m_ConnectedCallback and thereby destroys the std::function while it's running resulting in undefined behavior. By operating on a copy, m_ConnectedCallback can be set without affecting the currently running callback.
This fixes a bug introduced by #8933 (with that PR, the callback is replaced from within the callback). In my case, this showed by IcingaDB deadlocking.