Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icinga DB: HDEL also icinga:checksum:*:state, not only icinga:*:state #8919

Merged
merged 4 commits into from
Jul 29, 2021
Merged

Icinga DB: HDEL also icinga:checksum:*:state, not only icinga:*:state #8919

merged 4 commits into from
Jul 29, 2021

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented Jul 22, 2021 •
edited
Loading

... as they belong together.

@Al2Klimov Al2Klimov added bug Something isn't working area/icingadb New backend labels Jul 22, 2021
@Al2Klimov Al2Klimov added this to the 2.13.0 milestone Jul 22, 2021
@Al2Klimov Al2Klimov self-assigned this Jul 22, 2021
@Al2Klimov
Copy link
Member Author

Before

1626956715.971981 [0 127.0.0.1:61562] "HDEL" "icinga:host" "f1ab6f1fd99deed97a1408ed2ce7618b45713acb"
1626956715.972031 [0 127.0.0.1:61562] "XADD" "icinga:runtime" "MAXLEN" "~" "1000000" "*" "redis_key" "icinga:host" "id" "f1ab6f1fd99deed97a1408ed2ce7618b45713acb" "runtime_type" "delete"
1626956715.972104 [0 127.0.0.1:61562] "HDEL" "icinga:host:state" "f1ab6f1fd99deed97a1408ed2ce7618b45713acb"
1626956715.972140 [0 127.0.0.1:61562] "ZREM" "icinga:nextupdate:host" "f1ab6f1fd99deed97a1408ed2ce7618b45713acb"

After

1626956818.377510 [0 127.0.0.1:61599] "HDEL" "icinga:host" "f1ab6f1fd99deed97a1408ed2ce7618b45713acb"
1626956818.377623 [0 127.0.0.1:61599] "XADD" "icinga:runtime" "MAXLEN" "~" "1000000" "*" "redis_key" "icinga:host" "id" "f1ab6f1fd99deed97a1408ed2ce7618b45713acb" "runtime_type" "delete"
1626956818.377680 [0 127.0.0.1:61599] "HDEL" "icinga:host:state" "f1ab6f1fd99deed97a1408ed2ce7618b45713acb"
1626956818.377692 [0 127.0.0.1:61599] "HDEL" "icinga:checksum:host:state" "f1ab6f1fd99deed97a1408ed2ce7618b45713acb"
1626956818.377703 [0 127.0.0.1:61599] "ZREM" "icinga:nextupdate:host" "f1ab6f1fd99deed97a1408ed2ce7618b45713acb"

@Al2Klimov
Copy link
Member Author

Blocked by

@Al2Klimov Al2Klimov mentioned this pull request Jul 22, 2021
Merged
@Al2Klimov
Icinga DB: write state updates to icinga:runtime:state
8a30657 
... allowing the Go daemon to priorize state updates.
@Al2Klimov
Copy link
Member Author

Will conflict after

@Al2Klimov
Icinga DB: priorize state > config
ae9b371 
I.e. do the following in parallel (highest priority first):

* Stream state changes to icinga:runtime:state
* Sync config and initial state,
  then let queued runtime updates to the just synced state pass
@Al2Klimov
Icinga DB: HDEL from *:state with same prio as HSET
392fd8a 
... to ensure the right modifications order per key.
@Al2Klimov
Icinga DB: HDEL also icinga:checksum:*:state, not only icinga:*:state
fcda3a7 
... as they belong together.
@julianbrost julianbrost self-requested a review July 28, 2021 13:46
@julianbrost
Copy link
Contributor

Reviewing under the assumption that the draft state is now obsolete given that all references PRs are merged.

Only new commit is fcda3a7 (8a30657 and ae9b371 are from #8915 and 392fd8a is from #8917)

@Al2Klimov Al2Klimov marked this pull request as ready for review July 29, 2021 09:08
@Al2Klimov Al2Klimov merged commit 5923950 into master Jul 29, 2021
@icinga-probot icinga-probot bot deleted the bugfix/idb-del-state-chksm branch July 29, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianbrost julianbrost julianbrost approved these changes

Assignees

@Al2Klimov Al2Klimov

Labels
area/icingadb New backend bug Something isn't working
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Al2Klimov @julianbrost