Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for issue #6: Feature: Enhance desktop version #10

Merged
merged 9 commits into from
May 16, 2024

Conversation

ITurres
Copy link
Owner

@ITurres ITurres commented May 9, 2024

Pull Request Summary for Issue #6 Completion

Overview:

This pull request is to address issue #6. The idea is to enhance the desktop layout by giving it a slightly different look than the mobile layout.

Changes Made:

Added:

  • n/a.

Modified:

  • .env.sample

    • Updated the REACT_APP_FMP_KEY value to REACT_APP_FMP_API_KEY.
  • .gitignore

    • Added pr.md and .env.
  • /src/components/CompanyCard.tsx

    • Added style class company-card to Card element.
    • Updated Card.Img element style class to company-card__logo.
  • /src/pages/CompanyPage.tsx

    • Added a second img element with the same company logo, to be displayed as blurred in the background.
    • Added my-container style class to the h5 element.
  • /src/pages/Home.tsx

    • Updated img 'hero' logo class from hero to hero__logo.
    • Added hero__text to title container.
  • /src/styles/index.scss

    • Added new custom property --bright-pink-2-opacity to be used for the company's cards on desktop.
    • Updated classes and added breakpoints for the new custom desktop layout.

Deleted:

  • n/a.

Impact:

  • This will impact the desktop layout and the img logo on the mobile layout.

Testing:

  • All tests remain passing.

Related Issues:

Dependencies:

  • n/a.

Additional Notes:


@ITurres ITurres added enhancement New feature or request UI/UX redeploy gh-pages deployment labels May 9, 2024
@ITurres ITurres self-assigned this May 9, 2024
@ITurres ITurres linked an issue May 9, 2024 that may be closed by this pull request
@ITurres ITurres marked this pull request as ready for review May 16, 2024 01:11
@ITurres
Copy link
Owner Author

ITurres commented May 16, 2024

✅ Good for merge.

@ITurres ITurres merged commit cfd5e6b into development May 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request redeploy gh-pages deployment UI/UX
Projects
Development

Successfully merging this pull request may close these issues.

Enhance the Desktop Version of the App
1 participant