Improve WidgetInterface API #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dyollb
commented
Apr 10, 2018
dyollb
commented
- added several slots and signals to base class WidgetInterface
- use override in all WidgetInterface derived classes
- updated code in derived classes and mainly in Mainwindow::tab_changed and Mainwindow::(dis)connect_mouseclick, i.e. widget specific signal-slot connections could be replaced by generic code
- renamed folder Plugin->Interface, and moved some basic classes from Core to Interface (e.g. Point)
- renamed Addon files to Plugin files
- fixed capitalization in file names in Core/iSeg
added 9 commits
April 9, 2018 09:28
…lice change, etc.) added basic fix/hack to copy plugins to bundle on osx
- added signals and slots to base widget class - replaced pt_clicked by mouse_clicked (moved/released) - simplified connection/disconnection of slots in Mainwindow - added todos - biggest worry is currently: on_tissuenr_changed -> what is meaning of index passed to callback, how is it used (offset -1 all over the code makes things really confusing)
instead of calling cleanup for specific widgets, base class now has cleanup API, and Mainwindow calls it in generic block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.