Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill qt3 #126

Merged
merged 12 commits into from
Feb 14, 2022
Merged

Kill qt3 #126

merged 12 commits into from
Feb 14, 2022

Conversation

dyollb
Copy link
Member

@dyollb dyollb commented Feb 3, 2022

towards getting rid of qt3support, and eventually moving to qt5 and qt6 (see issue #80)

  • replaced use of qt3 layout classes
  • replace qt3 function api, e.g. .ascii()
  • refactor conversion from QString to std::string / const char*

@dyollb dyollb requested a review from sanderegg February 3, 2022 08:29
@dyollb dyollb requested a review from a team as a code owner February 3, 2022 08:29
@dyollb dyollb self-assigned this Feb 3, 2022
sanderegg
sanderegg reviewed Feb 3, 2022
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see some C++ code for a change ;)

CMake/ThirdPartyQt4.cmake Show resolved Hide resolved
@dyollb dyollb merged commit 985f82d into ITISFoundation:master Feb 14, 2022
@dyollb dyollb mentioned this pull request Feb 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

Assignees

@dyollb dyollb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyollb @sanderegg