Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ptz-controller and autor-calibrator modules #51

Conversation

ralatsdc
Copy link

Modules include:

  • Complete unit testing
  • Integration testing using MQTT, standalone or in a container
  • Configuration in the environment, or through a configuration message

The modules were validated running in separate containers on the SkyScan-11 system.

@github-actions
Copy link

Validation Issues Found (Python) 🐍

File: ptz-controller/test_messages.py
Line Number: 76
Statement(s):

        self.camera_pointing_file = open(self.camera_pointing_filename, "w") 

Rule:
file object opened without corresponding close

File: auto-calibrator/auto_calibrator.py
Line Number: 136
Statement(s):

            sleep(1) 

Rule:
time.sleep() call; did you mean to leave this in?

File: auto-calibrator/auto_calibrator.py
Line Number: 608
Statement(s):

                sleep(0.001) 

Rule:
time.sleep() call; did you mean to leave this in?

File: auto-calibrator/test_messages.py
Line Number: 59
Statement(s):

        time.sleep(5) 

Rule:
time.sleep() call; did you mean to leave this in?

File: ptz-controller/ptz_controller.py
Line Number: 184
Statement(s):

            sleep(1) 

Rule:
time.sleep() call; did you mean to leave this in?

File: ptz-controller/test_messages.py
Line Number: 71
Statement(s):

        time.sleep(5) 

Rule:
time.sleep() call; did you mean to leave this in?

Raymond LeClair added 2 commits April 14, 2023 17:55
…' of github.com:ralatsdc/SkyScan into rl/accumulate-data-and-pointing-error-without-lead-time
@github-actions
Copy link

Validation Issues Found (Python) 🐍

File: ptz-controller/test_messages.py
Line Number: 76
Statement(s):

        self.camera_pointing_file = open(self.camera_pointing_filename, "w") 

Rule:
file object opened without corresponding close

File: auto-calibrator/auto_calibrator.py
Line Number: 136
Statement(s):

            sleep(1) 

Rule:
time.sleep() call; did you mean to leave this in?

File: auto-calibrator/auto_calibrator.py
Line Number: 608
Statement(s):

                sleep(0.001) 

Rule:
time.sleep() call; did you mean to leave this in?

File: auto-calibrator/test_messages.py
Line Number: 59
Statement(s):

        time.sleep(5) 

Rule:
time.sleep() call; did you mean to leave this in?

File: ptz-controller/ptz_controller.py
Line Number: 184
Statement(s):

            sleep(1) 

Rule:
time.sleep() call; did you mean to leave this in?

File: ptz-controller/test_messages.py
Line Number: 71
Statement(s):

        time.sleep(5) 

Rule:
time.sleep() call; did you mean to leave this in?

@mchadwick-iqt
Copy link
Contributor

These have been converted into EdgeTech Core modules and will not be merged into the main SkyScan repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants