Update v2 #19
Merged
Update v2 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Former-commit-id: e43ed6987551bce997ce1b03fe80c0d9c52f1d40
Former-commit-id: 52cb00d34eb708b9acb01831d0be0c0190bdfde5
Former-commit-id: 92cda3b7c976cf87f898cd33ae25be6ba52887c9
Former-commit-id: 72bc96c5811125e038afebea7c39fc66a518fd06
Former-commit-id: 81bf06e9296415a8e47a69844cb3a9f965a62f41
Former-commit-id: 6fd5abfdbfc05b46b98fd3c441c980265178c020
Former-commit-id: 2980460f292d8f1e515583ffda69d1eeeb4520e0
Former-commit-id: 8e030db2cc926f5a5bc2b0186b78e7f309238fbc
Former-commit-id: f1dd4b5bcdc6f5f63db4ff5fa3e16e0f0799b35c
Former-commit-id: e00f44353c011245ac2e2fc2c98cf0fa91f5436a
Former-commit-id: 9901dfe83a99d37f110efc35673a23082831791d
Model train
jspeed-meyers
added
documentation
|
@mchadwick-iqt, does this look right to you? Of course, this operation is not as simple as I would like it to be. |
rcaudill
approved these changes
Nov 15, 2021
|
@jspeed-meyers - I pushed a new commit to remove a number of obsolete files that had been retained with the merge. Can you do a quick once-over and make sure we're still good from your perspective? |
|
@mchadwick-iqt, It looks good to me. I am going to look at it one more time with fresh eyes tomorrow morning and then I'll merge. |
jspeed-meyers
commented
Nov 16, 2021
| @@ -4,5 +4,5 @@ services: | |||
| axis-ptz: | |||
| command: /bin/sh -c "while sleep 1000; do :; done" | |||
| volumes: | |||
| - /home/pi/Projects/SkyScan/axis-ptz:/workspace:cached # Additional bind mount | |||
| - /home/pi/Projects/SkyScan-Private/axis-ptz:/workspace:cached # Additional bind mount | |||
There was a problem hiding this comment.
@rcaudill, is this use of a different volume path a problem?
mchadwick-iqt
pushed a commit
that referenced
this pull request
Nov 16, 2021
Web status Former-commit-id: dbf96fb6813361d883c76a7fe11203503e92556c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rob, this is an attempt to merge back in the progress from the private fork into the public fork. Does it look right to you? Can you please take a look and let me know?
JS