fix: test meta model - MMField value(Item)Type is not implicit #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monperrus
reviewed
Nov 28, 2017
|
|
||
| mmField.forEachUnhandledMethod(ctMethod -> problems.add("Unhandled method signature: " + ctMethod.getDeclaringType().getSimpleName() + "#" + ctMethod.getSignature())); | ||
| }); | ||
| }); | ||
|
|
||
| unhandledRoles.forEach(it -> problems.add("Unused CtRole." + it.name())); | ||
|
|
||
| assertTrue(String.join("\n", problems), problems.isEmpty()); | ||
| // assertTrue(String.join("\n", problems), problems.isEmpty()); |
There was a problem hiding this comment.
explain why this assertion is commented out and when we'll be able to get it back?
monperrus
reviewed
Nov 28, 2017
| @@ -36,7 +36,6 @@ | |||
| */ | |||
| //enable this test after everything is covered. | |||
| @Test | |||
| @Ignore | |||
There was a problem hiding this comment.
remove line comment " //enable this test after everything is covered. "?
|
thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value type of MMField
CtLiteral#valuewas Object with implicit = true, which caused problem in new template substitution and then invalid pretty printing of such type references... DJPP doesn't prints such TypeReferences, even if they are on place where they cannot be implicit.