Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default keyword values for main IIIF objects #131

Merged
merged 4 commits into from
Mar 11, 2022

Conversation

giacomomarchioro
Copy link
Contributor

This pull request add the default keywords to the JSON shema for the main IIIF object classes.

E.g. the default keyword for Manifest type is "Manifest".

The default keywords are useful for solving iiif-prezi/iiif-prezi3#12.

@glenrobson
Copy link
Member

Can we drop 3.6 in the test and add 3.10 which is the latest python version.

@glenrobson
Copy link
Member

Glen to create a new pull request and let Giacomo know when its ready.

@glenrobson
Copy link
Member

I've just been looking at something and came across a const keyword:

https://json-schema.org/understanding-json-schema/reference/generic.html#constant-values

Would this be more suitable than default?

@giacomomarchioro
Copy link
Contributor Author

I've just been looking at something and came across a const keyword:

https://json-schema.org/understanding-json-schema/reference/generic.html#constant-values

Would this be more suitable than default?

Yes, it makes much more sense from the semantic point of view, however, all my attempts using datamodel-codegen failed, maybe it is linked with this issue: koxudaxi/datamodel-code-generator#658

@glenrobson
Copy link
Member

Ah thats a shame. Oh well maybe we can change it to const when its supported.

I've removed python 3.6 from the main branch so if you update the tests should work then and I can merge.

@glenrobson
Copy link
Member

git checkout main
git pull origin 
git checkout defaulttypevalue
git merge main
git push

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.231% when pulling 0da122b on giacomomarchioro:defaulttypevalue into 1590fae on IIIF:main.

@glenrobson glenrobson merged commit 1e3d9df into IIIF:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants