-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default keyword values for main IIIF objects #131
Conversation
Can we drop 3.6 in the test and add 3.10 which is the latest python version. |
Glen to create a new pull request and let Giacomo know when its ready. |
I've just been looking at something and came across a https://json-schema.org/understanding-json-schema/reference/generic.html#constant-values Would this be more suitable than |
Yes, it makes much more sense from the semantic point of view, however, all my attempts using datamodel-codegen failed, maybe it is linked with this issue: koxudaxi/datamodel-code-generator#658 |
Ah thats a shame. Oh well maybe we can change it to I've removed python 3.6 from the main branch so if you update the tests should work then and I can merge. |
|
Default value added to jsonschema
This pull request add the default keywords to the JSON shema for the main IIIF object classes.
E.g. the default keyword for Manifest type is "Manifest".
The default keywords are useful for solving iiif-prezi/iiif-prezi3#12.