Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support recognizing *.rgba file (raw RGB with alpha channel) #552

Closed
wants to merge 5 commits into from

Conversation

for13to1
Copy link
Contributor

@for13to1 for13to1 commented Dec 6, 2023

image

*.rgba file suffix can present raw RGB file with alpha channel.
I was comfirmed that YUView support this type raw file with alpha.
But the experience of opening files is not smooth, because these extension suffix is not supported.

Like this:
image
image

After a sort of settings about formats, it finally can be shown on the screen:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modification here is as mentioned at #548 :

This style can work both on signed or unsigned integer type definition: only positive values are valid, which means it allow using signed interger declaration.

I suppose it would be more universal, although it changes no actual functionality.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some more consideration I have to agree with you. This a bit more clear and also more readable. Also, if we go to using integers (which would be the better solution) then this would still be correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your approval.

@ChristianFeldmann
Copy link
Member

Thx again for the issue. Fixed it a bit differently in #554.

@for13to1
Copy link
Contributor Author

Thx again for the issue. Fixed it a bit differently in #554.

You are welcome. I am glad to see it is merged. Then I can open these type RGBA files more smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants