Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache dir #123

Merged
merged 5 commits into from
Apr 14, 2023
Merged

add cache dir #123

merged 5 commits into from
Apr 14, 2023

Conversation

positive666
Copy link
Contributor

add cache_dir, default:None

@SlongLiu
Copy link
Collaborator

Hello, thanks for your contribution.

I will merge the PR. But the default value of cache_dir should be None rather than "None".

Suggested code:

from typing import Optional

parser.add_argument("--cache_dir", type=Optional[str], default=None, help="save your huggingface large model cache")

@SlongLiu SlongLiu merged commit 971a9f2 into IDEA-Research:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants