Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1401 #1402

Merged
merged 3 commits into from
May 15, 2024
Merged

fix #1401 #1402

merged 3 commits into from
May 15, 2024

Conversation

PaulJonasJost
Copy link
Collaborator

@PaulJonasJost PaulJonasJost commented May 14, 2024

Works with MacOs-13. Could not reproduce with MacOs-14.2 on local computer. Bergen this for now before searching a complete day for a system specific bug for now.

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (1206dc0) to head (4c1bb3a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1402      +/-   ##
===========================================
- Coverage    84.51%   84.50%   -0.02%     
===========================================
  Files          157      157              
  Lines        12958    12958              
===========================================
- Hits         10952    10950       -2     
- Misses        2006     2008       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Doresic Doresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PaulJonasJost PaulJonasJost marked this pull request as ready for review May 15, 2024 08:52
@PaulJonasJost PaulJonasJost requested a review from m-philipps as a code owner May 15, 2024 08:52
@PaulJonasJost PaulJonasJost merged commit 63c5662 into develop May 15, 2024
18 checks passed
@PaulJonasJost PaulJonasJost deleted the fix_roadrunner_test branch May 15, 2024 08:52
This was referenced May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants