Skip to content
This repository has been archived by the owner on May 27, 2021. It is now read-only.

DO NOT MERGE #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DO NOT MERGE #36

wants to merge 2 commits into from

Conversation

rhagarty
Copy link
Member

@rhagarty rhagarty commented Jun 5, 2018

  • update to new VisRec V3
  • get VR key from VCAP services
  • new plan name in manifest.yaml

Copy link
Member

@scottdangelo scottdangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious about the debug?

@@ -99,6 +97,7 @@ function detectFacesVR(filename) {
} catch (e) {
reject(e);
}
log.debug('calling visualRecognition detectFaces', params);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you want this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really. was hoping it would help isolate what call was generating the error

@@ -125,6 +124,7 @@ function recognizeTextVR(filename) {
} catch (e) {
reject(e);
}
log.debug('calling visualRecognition recoognizeText', params);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you want this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed these debug calls in new commit

@rhagarty
Copy link
Member Author

rhagarty commented Jun 5, 2018

will fix lint issues shortly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants