-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.12 #825
Support Python 3.12 #825
Conversation
0f2e0b5
to
7043d0d
Compare
7043d0d
to
589fc56
Compare
@glatterf42 please rebase |
This PR is rebased on the latest main as indicated by the "9 files changes" and ~20 lines affected. Let me check the test failures. |
Even though I've run the exact same install command locally as in the GHA, namely
I don't know which one of these might be affecting the tests, but since my local install command didn't install them and all tests are passing, I'm guessing they are installed unintentionally. @danielhuppmann, @phackstock, any idea why this is happening? Could this be related to the bump of the setuptools minimum version?
|
So the step "Install dependencies and package" includes these lines: Preparing metadata (pyproject.toml): started
Preparing metadata (pyproject.toml): finished with status 'done' Even though there is no When setting up a new project with poetry, it will ask you which version your project is one. Per default, this is 0.1.0, which would be written to Either way, I'm currently preparing a poetry-PR based on this branch, which will include a proper |
@phackstock in #818 updated the GitHub-Action versions for checkout and setup, maybe that implied some default-to-toml routine? |
I'm just noticing that the packages listed above seem installed on my system after all, it's just that |
That was just an update to the latest versions and didn't break anything in that PR. So I don't think that that would break anything now. Plus @glatterf42 made the same updates in this PR to the other workflow files and they run fine. |
Regarding the package version discrepancies that you reported, did you do your local installation from a fresh virtual environment or did you already have a previous version of pyam and its dependencies installed. If it's the latter that could explain the differences since the GH action always starts from scratch. |
The failing tests have nothing to do with the pyam-version issue, that is just that @glatterf42 removed the matplotlib version pin. |
Ah ok I see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like matplotlib 3.8 uses a lighter, larger font on the axis-labels - I like it. And that also explains why the plotting-tests failed...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #825 +/- ##
=====================================
Coverage 94.8% 94.8%
=====================================
Files 64 64
Lines 6092 6092
=====================================
Hits 5778 5778
Misses 314 314 ☔ View full report in Codecov by Sentry. |
Please confirm that this PR has done the following:
Description of PR
Supersedes #820 and adds support for Python 3.12.
Please note: this PR is based locally on top of #821, so we will need to rebase this onto main once that PR is merged.