New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out Shrinker and loop shrinks to a fixed point #21

Merged

DRMacIver merged 1 commit into development from DRMacIver/better-shrinking

Feb 15, 2018

Member

DRMacIver commented Feb 14, 2018

This updates the shrink logic in two ways:

When shrinking has "completed" we now restart from the beginning, and we keep doing that until it hits a fixed point.
Factors out the shrink logic into a separate Shrinker type that is used to store the shrink state. A nice consequence of this is that we now have better state management in the main loop - there's no longer always a shrink_target field that may or may not be in an invalid state.

(Builds on top of #19 because that version of the code is way less broken. Will update base once it's merged)

DRMacIver force-pushed the DRMacIver/termination-is-error branch from 07b579f to 42c90da Compare

February 15, 2018 06:58

DRMacIver changed the base branch from DRMacIver/termination-is-error to development

February 15, 2018 08:17


Factor out Shrinker and loop shrinks to a fixed point

d1ecb14

DRMacIver force-pushed the DRMacIver/better-shrinking branch from 303ac2b to d1ecb14 Compare

February 15, 2018 08:20

DRMacIver merged commit 4b2fbc3 into development

DRMacIver deleted the DRMacIver/better-shrinking branch

February 15, 2018 19:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment