Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Assign a topic to every selected item (closes #159) #201

Draft
wants to merge 2 commits into
base: v7
Choose a base branch
from
Draft

Conversation

TomikaArome
Copy link

@TomikaArome TomikaArome commented Jun 16, 2019

Content

Checklist

Please check that your pull request is correct:

  • Each commit:
    • corresponds to a contribution that should be notified to users,
    • does not generate new errors or warnings at compile or test time,
    • must be attributed to its real authors (with correct GitHub IDs and correct syntax for multiple authors).
  • The title of a commit should:
    • begin with a contribution type
      • FEATURE for a behaviour allowing a user to do something new,
      • FIX for a behaviour which has been changed in order to meet user’s expectations,
      • TEST when it concerns an acceptance test,
      • PROCESS for a change in the way the software is built, tested, deployed,
      • DOC when it concerns only internal documentation (however it is better to combine it with the contribution that required this documentation change),
    • be followed by a colon (:) with one space after and no space before,
    • be followed by a title (written in English) as short, as user-centered and as explicit as possible
      • If it is a feature, the title must be the user action (beginning with a verb, and please not manage),
      • If it is a fix, the title must describe the intended behavior (with should).
    • ends with a reference to the corresponding ticket with the following syntax:
      • (closes #xx) if xx is a feature ticket (and the commit is a complete implementation),
      • (fixes #xx) if xx is a fix ticket (and the commit is a complete fix),
      • (see #xx) otherwise,
  • Each committed line is:
    • useful (it would not work if removed)
      • if it is a comment line, its information could not be conveyed by better variables and function naming, better code structuring, or better commit message,
    • related to this very contribution (feature, fix...),
    • in English (with the exception of Gherkin scenarios in French and resulting steps),
    • without any typo in variable, class or function names,
    • correctly indented (spaces rather than tabs, same number of characters as in the rest of the file).

@TomikaArome TomikaArome requested a review from benel June 16, 2019 21:21
@TomikaArome TomikaArome changed the title FEATURE: Assign a topic to every selected item FEATURE: Assign a topic to every selected item (closes: Porphyry#159) Jun 16, 2019
@TomikaArome TomikaArome changed the title FEATURE: Assign a topic to every selected item (closes: Porphyry#159) FEATURE: Assign a topic to every selected item (closes: #159) Jun 16, 2019
@benel
Copy link
Member

benel commented Jun 17, 2019

Please edit the history to comply with the checklist.

Please note also that a standard pull request should only have two commits: one for the feature and the other for the test. You can have one or two additional fixes, but certainly not 10 commits.

@TomikaArome TomikaArome changed the title FEATURE: Assign a topic to every selected item (closes: #159) FEATURE: Assign a topic to every selected item (closes #159) Jun 20, 2019
@benel benel added the Draft label Mar 19, 2020
@benel benel marked this pull request as draft April 29, 2020 09:48
@benel benel removed the Draft label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants