fix bitwise extended type, fixed memleaks, remove excess else and cmp…

… int with EOF
HyperDbg · Apr 5, 2024 · 7bcf1e5 · 7bcf1e5
1 parent 103874d
commit 7bcf1e5
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 4 deletions.
diff --git a/hyperdbg/hprdbgctrl/code/debugger/script-engine-wrapper/script-engine-wrapper.cpp b/hyperdbg/hprdbgctrl/code/debugger/script-engine-wrapper/script-engine-wrapper.cpp
@@ -673,6 +673,7 @@ ScriptEngineWrapperTestParser(const string & Expr)
  if (RspReg == NULL)
  {
  ShowMessages("err, unable to allocate stack for script engine tests");
+ free(TestStruct);
  return;
  }
 

diff --git a/hyperdbg/hprdbghv/code/common/Common.c b/hyperdbg/hprdbghv/code/common/Common.c
@@ -25,7 +25,7 @@ CommonAffinityBroadcastToProcessors(ULONG ProcessorNumber, RunOnLogicalCoreFunc
 {
  KIRQL OldIrql;
 
- KeSetSystemAffinityThread((KAFFINITY)(1 << ProcessorNumber));
+ KeSetSystemAffinityThread((KAFFINITY)(1ULL << ProcessorNumber));
 
  OldIrql = KeRaiseIrqlToDpcLevel();
 

diff --git a/hyperdbg/hprdbghv/code/vmm/vmx/Vmx.c b/hyperdbg/hprdbghv/code/vmm/vmx/Vmx.c
@@ -1385,7 +1385,7 @@ VmxGetSegmentDescriptor(PUCHAR GdtBase, UINT16 Selector, PVMX_SEGMENT_SELECTOR S
 
  SegmentSelector->Selector = Selector;
  SegmentSelector->Limit = __segmentlimit(Selector);
- SegmentSelector->Base = (Descriptor32->BaseAddressLow | Descriptor32->BaseAddressMiddle << 16 | Descriptor32->BaseAddressHigh << 24);
+ SegmentSelector->Base = ((UINT64)Descriptor32->BaseAddressLow | (UINT64)Descriptor32->BaseAddressMiddle << 16 | (UINT64)Descriptor32->BaseAddressHigh << 24);
 
  SegmentSelector->Attributes.AsUInt = (AsmGetAccessRights(Selector) >> 8);
 

diff --git a/hyperdbg/script-engine/code/common.c b/hyperdbg/script-engine/code/common.c
@@ -41,6 +41,7 @@ NewUnknownToken()
  //
  // There was an error allocating buffer
  //
+ free(Token);
  return NULL;
  }
 
@@ -85,6 +86,7 @@ NewToken(TOKEN_TYPE Type, char * Value)
  //
  // There was an error allocating buffer
  //
+ free(Token);
  return NULL;
  }
 
@@ -329,6 +331,7 @@ CopyToken(PTOKEN Token)
  //
  // There was an error allocating buffer
  //
+ free(TokenCopy);
  return NULL;
  }
 

diff --git a/hyperdbg/script-engine/code/scanner.c b/hyperdbg/script-engine/code/scanner.c
@@ -632,7 +632,6 @@ GetToken(char * c, char * str)
  *c = sgetc(str);
  return Token;
  }
- else
 
  default:
  if (*c >= '0' && *c <= '9')
@@ -898,7 +897,7 @@ Scan(char * str, char * c)
 
  Token = GetToken(c, str);
 
- if ((char)*c == EOF)
+ if ((int)*c == EOF)
  {
  ReturnEndOfString = TRUE;
  }

diff --git a/hyperdbg/script-engine/code/script-engine.c b/hyperdbg/script-engine/code/script-engine.c
@@ -2373,6 +2373,7 @@ NewFunctionSymbol(char * FunctionName, VARIABLE_TYPE * VariableType)
  //
  // There was an error allocating buffer
  //
+ free(Symbol);
  return NULL;
  }
 
@@ -2383,6 +2384,7 @@ NewFunctionSymbol(char * FunctionName, VARIABLE_TYPE * VariableType)
  //
  // There was an error allocating buffer
  //
+ free(Symbol);
  return NULL;
  }
 

diff --git a/hyperdbg/symbol-parser/code/symbol-parser.cpp b/hyperdbg/symbol-parser/code/symbol-parser.cpp
@@ -1003,6 +1003,7 @@ SymGetFieldOffset(CHAR * TypeName, CHAR * FieldName, UINT32 * FieldOffset)
  if (FieldNameW == NULL)
  {
  printf("err, could not allocate buffer");
+ free(TypeNameW);
  return FALSE;
  }