Fix version checking hang in offline deployment #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add timeout to version check
|
I think timeout=10 is a bit long but in some cases necessary, please feel free to suggest other values |
|
Thanks @makseq for your prompt answer! |
makseq
added a commit
that referenced
this pull request
Jan 22, 2021
* Remove hostname prefix for upload files in case of localhost * Update misc.py (#560) Add timeout to version check * Update requests dependency * Add task patch * Fix task patch docs * Add list to Image in validation * Change attrs version to >=19.1.0 * Main page mock-up fixes Gaps and overlays Outliers on mobile screens Simplify sliders and fix console error about missing one Fix github stars rounding Add new release with github link * Add INIT_COMMAND to run.sh * Update DM build * Add editor version to hash * Fix misspell * Change LS version * Fix misspell Co-authored-by: LamDang <[email protected]> Co-authored-by: hlomzik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add timeout to version check
Fix #558