Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure project summary consistent on project saving/validation #1178

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

niklub
Copy link
Collaborator

@niklub niklub commented Jul 12, 2021

In some cases (e.g. bulk removals of tasks/annotations) project summary is not updated correctly. This workaround helps to keep the project summary consistent with empty projects

@niklub niklub requested a review from makseq July 12, 2021 20:56
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #1178 (ab721e4) into master (007220c) will increase coverage by 3.60%.
The diff coverage is 89.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1178      +/-   ##
==========================================
+ Coverage   70.15%   73.75%   +3.60%     
==========================================
  Files         113      115       +2     
  Lines        7576     7720     +144     
==========================================
+ Hits         5315     5694     +379     
+ Misses       2261     2026     -235     
Impacted Files Coverage Δ
label_studio/core/middleware.py 86.07% <ø> (-1.71%) ⬇️
label_studio/data_export/urls.py 100.00% <ø> (ø)
label_studio/data_import/urls.py 100.00% <ø> (ø)
label_studio/data_manager/api.py 77.63% <ø> (-0.14%) ⬇️
label_studio/data_manager/models.py 94.73% <ø> (ø)
label_studio/organizations/models.py 68.29% <ø> (ø)
label_studio/projects/urls.py 100.00% <ø> (ø)
label_studio/users/forms.py 89.47% <ø> (+10.80%) ⬆️
label_studio/organizations/functions.py 76.92% <50.00%> (-23.08%) ⬇️
label_studio/core/version.py 63.93% <61.90%> (+1.67%) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a553e2...ab721e4. Read the comment docs.

@niklub niklub merged commit 823e315 into master Jul 12, 2021
@nicholasrq nicholasrq deleted the fix/project-summary-consistency branch August 12, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants