Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to lualatex to generate the documentation PDF #826

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

ernestum
Copy link
Collaborator

@ernestum ernestum commented Dec 6, 2023

The documentation pipeline was failing only on the master branch.
This is due to the fact that only for commits on master readthedocs tries to generate a PDF.

PDF generateion failed since latex ran out of memory.

Let's see if luatex can do better.

Note: to test if this PR works we unfortunately need to merge it into master since the PDF output is only generated for
master builds.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3649188) 95.66% compared to head (f7ab91e) 95.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
- Coverage   95.66%   95.64%   -0.02%     
==========================================
  Files         102      102              
  Lines        9655     9655              
==========================================
- Hits         9236     9235       -1     
- Misses        419      420       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AdamGleave AdamGleave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- let's give LuA a try!

@AdamGleave AdamGleave merged commit 629ef9a into master Dec 6, 2023
13 of 15 checks passed
@AdamGleave AdamGleave deleted the fix_documentation_pipeline branch December 6, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants