Skip to content

Commit

Permalink
Fix MacOS Pipeline: Include tests not in subdirectories (#797)
Browse files Browse the repository at this point in the history
* Fix glob expansion by adding quotes and add diagnostics

* Remove workaround no longer needed with Gymnasium

* Bugfix in sys.modules restore

* Try avoiding echo to prevent one big test filename
  • Loading branch information
AdamGleave authored Oct 5, 2023
1 parent 4e429ce commit cd76326
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
5 changes: 4 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,10 @@ jobs:
name: run tests
command: |
source ~/venv/bin/activate
TESTFILES=$(circleci tests glob tests/**/test*.py | circleci tests split --split-by=timings)
ALL_TESTFILES=$(circleci tests glob "tests/**/test*.py")
echo "All testfiles: ${ALL_TESTFILES}"
TESTFILES=$(circleci tests glob "tests/**/test*.py" | circleci tests split --split-by=timings)
echo "This shard testing: ${TESTFILES}"
pytest -n auto --junitxml=/tmp/test-reports/junit.xml -vv $TESTFILES
- save-pytest-cache
Expand Down
2 changes: 0 additions & 2 deletions docs/requirements.txt

This file was deleted.

2 changes: 0 additions & 2 deletions readthedocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ build:

python:
install:
# TODO(GH#707): remove docs/requirements.txt once Gym upgraded
- requirements: docs/requirements.txt
- method: pip
path: .
extra_requirements:
Expand Down
2 changes: 1 addition & 1 deletion tests/util/test_wb_logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,4 @@ def test_wandb_module_import_error():
with pytest.raises(ModuleNotFoundError, match=r"Trying to log data.*"):
logger.configure(format_strs=["wandb"])
finally:
sys.modules[wandb] = wandb_module
sys.modules["wandb"] = wandb_module

0 comments on commit cd76326

Please sign in to comment.