Feature/refactor all #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix gitea crawler - change cli command to accept a list of platform types
network preparations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think even if there is more to clean out/refactor - right now is a currently matching crawler-indexer relationship, and it makes sense to merge.
GitLab crawler still needs to be refactored to work against the current indexer and state setup, same with bitbucket if want to keep that (low prio ofc.).
Another point is, do we want to keep all the unused github crawlers (and bitbucket)? They do contain good information as to what we can/cant do as a note of "research" of sorts. Im not sure? I guess we keep them and litter the repo-structure.