Fix/handle ratelimit many crawlers #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoheelias
commented
Jul 13, 2021
| ] | ||
| } | ||
| """ | ||
| return list(map(lambda d: d["type"], errors)) |
There was a problem hiding this comment.
moved this to its own function even though its just a map, so we can have easier documentation/explanation for it without cluttering the main function
geoheelias
commented
Jul 13, 2021
| logger.debug(f"{error_types} - ratelimit was reached elsewhere - retry in {GITHUB_RATELIMIT_SLEEP}s") | ||
| time.sleep(GITHUB_RATELIMIT_SLEEP) | ||
| logger.debug(f"long ratelimit sleep over, retry query") | ||
| response = send_query() |
There was a problem hiding this comment.
so I have to look for this crappy error type, in that list, to know that something else consumed all our ratelimit, and then ill guess it happened just now and sleep for 1h before retrying - it sucks but theres no alternative when they dont give out the info after you reached the limit
There was a problem hiding this comment.
also, we only retry once - after that we get a skipped block chunk (and hole in our data)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.