This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
CSS refactoring #793
Merged
CSS refactoring #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
November 9, 2016 16:10
|
Exciting |
added 3 commits
November 9, 2016 19:43
and will do that in a separate PR
|
Settled on a path forward, and chatted with @jkleinsc a little bit today about all the changes. I'm going to merge this PR with just the structural cleanup of the existing styles, then open another PR for the next step. |
|
@jkleinsc not sure about this failure, but it appears to be blocking the test from passing.
Can you point me to what I need to do to resolve? |
|
@jkleinsc false alarm! It appears to have been an intermittent failure. I re-ran the test and it passed. ⚡ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on some major CSS refactoring. Still scoping out the best way to approach it, but getting the PR going nice and early.
Current plan is to:
I'm not sure yet how much of the above plan belongs in this particular PR. I'll probably merge and start a new PR a few times just to keep things from getting too big in this one PR.
EDIT: I've scoped the above list to just a couple things for this PR.
cc @HospitalRun/core-maintainers