Spanish translation updated #723

pixelead0 · 2016-10-11T20:22:20Z

Spanish translation updated based commit f8af165

Changes proposed in this pull request:

Spanish translation

Note: pull requests without proper descriptions may simply be closed without further discussion. We appreciate your contributions, but need to know what you are offering in clearly described format. Thanks! (you can delete this text)

cc @HospitalRun/core-maintainers

spanish translation updated with commit f8af165

jkleinsc

@pixelead0 thanks for the PR. It looks like there are some syntax errors in the translation:
``
SyntaxError: hospitalrun/locales/es/translations.js: Unexpected token (344:4)
anesthesia: 'Anestesia',
procedures: 'Procedimiento'
procedures: 'Procedimientos',
number: 'Número',
billDate: 'Fecha Factura',
balanceDue: 'Saldo Vencido',

You can verify these locally by running `ember test`

fgs-dbudwin

There may be other missing commas, but these are the two that I found!

fgs-dbudwin · 2016-10-12T18:30:56Z

app/locales/es/translations.js

 provider: 'Proveedor',
 with: 'con',
- allDay: 'Todo el dia',
+ allDay: 'Todo el día',
 physician: 'Médico',
 assisting: 'Asistencia',
 anesthesia: 'Anestesia',
 procedures: 'Procedimiento'


You're missing a comma after procedures: 'Procedimiento'. Change to procedures: 'Procedimiento', and it should work!

Shouldn't procedures be Procedimientos?

fgs-dbudwin · 2016-10-12T18:31:29Z

app/locales/es/translations.js

@@ -320,18 +407,39 @@ export default {
 dispense: 'Repartir',
 newItem: '+ nuevo elemento',
 newRequestPlus: '+ nuevo pedido',
- addVisit: 'Adicionar visita',
+ addVisit: 'Agregar visita',
 search: 'Buscar'


Same here, you'll need a comma after search: 'Buscar'

btecu · 2016-10-14T00:41:27Z

app/locales/es/translations.js

@@ -1,55 +1,94 @@
 export default {
 dashboard: {
- title: 'Que deseas hacer?'
+ title: '¿Qué deseas hacer?'


Perhaps use desea instead of deseas. The former is more formal (usted vs tu).

It is better to use formal writing in software.

btecu · 2016-10-14T00:45:45Z

app/locales/es/translations.js

+ purchaseSaved: 'Compras de Inventario Guardadas',
+ quickAddTitle: 'Nuevo Eelemento de Inventario',
+ removeItem: 'Remover Elemento',
+ requestFulfilled: 'Pedido Cumplido',


Complido -> Completo?

There is a typo in "Eelemento" -> Elemento

btecu · 2016-10-14T00:46:40Z

app/locales/es/translations.js

 },
 messages: {
- noCompleted: 'No de items encontrados.'
+ delete: 'Esta seguro de que desea eliminar esta solicitud de radiografía ?',


¿Está seguro...

Also, no space before ?

In spanish, we use opening question mark ¿, so in delete, is missing

btecu · 2016-10-14T00:47:52Z

app/locales/es/translations.js

- savedMessage: 'El pedido de radiografia ha sido guardado.'
+ completedTitle: 'Pedido de radiografía completado',
+ completedMessage: 'El pedido de radiografía ha sido completado.',
+ savedTitle: 'Pedido de radiografía salvado',


Did you mean guardado?

Salvado doesn't mean what you think it does:
http:https://dle.rae.es/?id=X7tj9JF

btecu · 2016-10-14T00:50:29Z

app/locales/es/translations.js

+ quantityDistributed: 'Cantidad Distribuida',
+ quantityToReturn: 'Cantidad a Devolver',
+ returnLocation: 'Retornar Ubicación',
+ returnAisle: 'Devolve Pasillo',


Devolve -> Devolver

Regresar sounds better than Retornar

btecu · 2016-10-14T00:51:05Z

app/locales/es/translations.js

- savedMessage: 'La elemento de medicación ha sido guardado.',
- fulfilledTitle: 'Pedido de medicación cumplido'
+ returnedTitle: 'Medicamento Devuelto',
+ returnedMessage: 'El medicamento ha sido marcado para devolver.',


Remove double space

Devuelto shouldn't be capitalized, since its a noun

btecu · 2016-10-14T00:52:07Z

app/locales/es/translations.js

+ height: 'Altura',
+ sbp: 'SBP',
+ dbp: 'DBP',
+ heartRate: 'Ritmo Cardiaco',


Cardiaco -> Cardíaco

same here, Cardíaco shouldn't be capitalized

btecu · 2016-10-14T00:58:09Z

Also, I'm unsure about the constant change of casing. It appears to be inconsistent.
I understand some are titles, but this is Spanish and therefore other rules apply. In Spanish, in titles only the first letter is capitalized (except if any other word is a name).

Here is what RAE says about it:

Se escriben con mayúscula la primera palabra del título de cualquier obra de creación (libros, películas, cuadros, esculturas, piezas musicales, programas de radio o televisión, etc.); el resto de las palabras que lo componen, salvo que se trate de nombres propios, deben escribirse con minúscula: Últimas tardes con Teresa, La vida es sueño, La lección de anatomía, El galo moribundo, Las cuatro estaciones, Las mañanas de la radio, Informe semanal. En el caso de los títulos abreviados con que se conocen comúnmente determinados textos literarios, el artículo que los acompaña debe escribirse con minúscula: el Quijote, el Lazarillo, la Celestina.

marcorosas1991 · 2016-11-22T03:36:17Z

app/locales/es/translations.js

+ invalid: 'es invalido',
+ confirmation: '{{attribute}} no corresponde',
+ accepted: 'debe ser aceptado',
+ empty: 'no puede ser vacío',


"estar" instead of "ser"

marcorosas1991

I reviewed the file and this corrections need to be done.

marcorosas1991 · 2016-11-22T03:36:37Z

app/locales/es/translations.js

+ confirmation: '{{attribute}} no corresponde',
+ accepted: 'debe ser aceptado',
+ empty: 'no puede ser vacío',
+ blank: 'no puede ser en blanco',


"estar" instead of "ser"

marcorosas1991 · 2016-11-22T03:38:48Z

app/locales/es/translations.js

+ accepted: 'debe ser aceptado',
+ empty: 'no puede ser vacío',
+ blank: 'no puede ser en blanco',
+ present: 'puede ser blanco',


based on the english text: 'must be blank' the translation should be 'debe estar en blanco'

if the same pattern aplies to the same context here, present should be debe estar presente since puede indicates "maybe"

marcorosas1991 · 2016-11-22T03:39:38Z

app/locales/es/translations.js

+ otherThan: 'debe ser diferente a {{count}}',
+ odd: 'debe ser impar',
+ even: 'debe ser par',
+ invalidNumber: 'número no válido',


is more proper to use 'inválido'

marcorosas1991 · 2016-11-22T03:41:52Z

app/locales/es/translations.js

+ admittedPatients: 'Pacientes Admitidos',
+ missed: 'Perdido',
+ userRoles: 'Perfiles de Usuarios',
+ workflow: 'Workflow'


flujo de trabajo

marcorosas1991 · 2016-11-22T03:45:33Z

app/locales/es/translations.js

 },
 loaddb: {
 progressMessage: 'Por favor espere mientras la base de datos es cargada.',
- progressTitle: 'Cargando ase de datos',
+ progressTitle: 'Cargando base de datos',
 displayAlertTitle: 'Seleccione un archivo para cargar',


cargar -> importar
to be consistent with other translated strings

marcorosas1991 · 2016-11-22T05:10:26Z

app/locales/es/translations.js

+ status: 'Estatus del Paciente',
+ externalPatientId: 'Número de Identificación del Paciente Externo',
+ bloodType: 'Tipo de Sangre',
+ clinic: 'Sitio Clinico',


Clinico -> Clínico

marcorosas1991 · 2016-11-22T05:12:50Z

app/locales/es/translations.js

+ charges: 'cargos'
+ },
+ takePhoto: {
+ how: '¿Como desea agregar una foto?',


Como -> Cómo

marcorosas1991 · 2016-11-22T05:13:42Z

app/locales/es/translations.js

+ },
+ errors: {
+ inclusion: 'no está incluido en la lista',
+ exclusion: 'es reservado',


'es' -> está

marcorosas1991 · 2016-11-22T05:24:07Z

app/locales/es/translations.js

@@ -443,31 +552,31 @@ export default {
 purchaseSaved: 'La compra de inventario ha sido salvada.',
 noRequests: 'No se encontraron pedidos.',
 noItems: 'No se encontraron elementos.',
- quantity: 'La cantidad total <strong>({{quantity}})</strong> no encaja con la cantidad total en las ubicaciones <strong>({{locationQuantity}})</strong>.',
+ quantity: 'La cantidad total <strong>({{quantity}})</strong> no concuerda con la cantidad total en las ubicaciones <strong>({{locationQuantity}})</strong>.',
 removeItem: 'Esta seguro de eliminar este elemento de la factura?',
 removeItemRequest: 'Seguro que quiere eliminar este elemento del pedido?',


'¿Está seguro...'

marcorosas1991 · 2016-11-22T05:24:37Z

app/locales/es/translations.js

+ deleteValueVisitTypeAdmissionTitle: 'No se puede eliminar admisión tipo visita',
+ deleteValueVisitTypeAdmissionMessage: 'Tipo de visita es necesaria para el módulo de admisiones.',
+ deleteValueVisitTypeImagingTitle: 'No se puede eliminar el tipo radiografía',
+ deleteValueVisitTypeImagingMessage: 'No se puede eliminar por que es necesario para el módulo de radiografías.',


'por que' -> porque

marcorosas1991 · 2016-12-10T05:25:58Z

I already posted some fixes that should be done with the translation. If you need further help let me know @pixelead0 . I am a native Spanish speaker, and I have studied professional Spanish at college.

tangollama · 2017-04-23T17:33:15Z

@pixelead0 we refactored the translation file to make it more maintainable. Are you amenable to updating and resubmitting this?

tangollama · 2017-05-23T16:53:57Z

@pixelead0 reply back if you're intending to try to respond to the feedback on this PR, even if the timeline is extended. That's fine. It's volunteer work. I just don't want to leave this open if it's not going anywhere.

pixelead0 added 2 commits October 10, 2016 14:06

spanish translation updated

9ac89cf

spanish translation updated with commit f8af165

Updated Spanish translation

57fd222

jkleinsc suggested changes Oct 12, 2016

View reviewed changes

fgs-dbudwin suggested changes Oct 12, 2016

View reviewed changes

btecu reviewed Oct 14, 2016

View reviewed changes

marcorosas1991 reviewed Nov 22, 2016

View reviewed changes

marcorosas1991 suggested changes Nov 22, 2016

View reviewed changes

tangollama closed this Aug 31, 2017

Spanish translation updated #723

Spanish translation updated #723

Conversation

pixelead0 commented Oct 11, 2016 • edited Loading

jkleinsc left a comment

Choose a reason for hiding this comment

fgs-dbudwin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

btecu commented Oct 14, 2016 • edited Loading

Choose a reason for hiding this comment

marcorosas1991 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcorosas1991 commented Dec 10, 2016

tangollama commented Apr 23, 2017

tangollama commented May 23, 2017

pixelead0 commented Oct 11, 2016 •

edited

Loading

btecu commented Oct 14, 2016 •

edited

Loading