Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

adding eslint to project #601

Closed
wants to merge 3 commits into from
Closed

adding eslint to project #601

wants to merge 3 commits into from

Conversation

charliewilco
Copy link

@charliewilco charliewilco commented Jul 20, 2016

Addresses #596.

  • adds eslint to project
  • jscs rules don't match one for one to eslint so that isn't an exact match for current linting set so i'm hoping for feedback on this PR

Other considerations

cc @HospitalRun/core-maintainers

@jkleinsc
Copy link
Member

@charlespeters thanks for the PR! Looking at https://github.com/DockYard/eslint-plugin-ember-suave it appears that it is still in progress and I would like to wait until that is stable to move over. I'm ok leaving this PR open until that happens.

@tangollama tangollama added 🚀enhancement an issue/pull request that adds a feature to the application Hack Day help wanted indicates that an issue is open for contributions and removed 🚀enhancement an issue/pull request that adds a feature to the application Hack Day help wanted indicates that an issue is open for contributions labels Sep 16, 2016
@jkleinsc
Copy link
Member

jkleinsc commented Oct 6, 2016

@charlespeters it looks like https://github.com/DockYard/eslint-plugin-ember-suave is ready to use:
https://dockyard.com/blog/2016/09/30/retiring-ember-suave

Would you be willing to update this PR so that we can move from ember-suave? Thanks!

@charliewilco
Copy link
Author

@jkleinsc now the fun part of this is that now we're using eslint, some of the tests are failing.

@jkleinsc jkleinsc closed this in 13a9a64 Oct 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants