Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

i8ln for the admin module #354

Closed
wants to merge 9 commits into from
Closed

Conversation

dswanson
Copy link

@tangollama tangollama added the in progress indicates that issue/pull request is currently being worked on label Mar 15, 2016
@billybonks
Copy link
Contributor

So my issue with this implementation which is my fault, since i didn't add any documentation during the initial implementation.

initially i designed the localization's file to have two main categories.
-labels
-messages
-titles

since then people have added
-buttons
-alerts

which is fine , they would have been merged into labels and messages.

any translation in these categories, if used in multiple places around the application would be in the first level of the hash. if they are only used in a specific place, they would be nested under there area for example a button in appointments would go under

appointments -> buttons -> myButton.

in this pr you are nesting them under admin, you have added route, i can understand why.

you have also added loaddb, and lookup. which i am not so sure about. i feel most of these could go under messages -> errors or something like that.

i am just opening up conversation, so that we can standardize the file.

@jkleinsc
Copy link
Member

@billybonks we are having an ongoing conversation on how to best organize the localizations. There are a couple of things we are thinking about:

  1. Reuse can potentially be an issue because depending upon language/context you may not want to reuse the value. I think there are some use cases where reuse is ok, but it probably should be used in moderation.
  2. Dividing the localizations into separate files per module and then importing them into the main translations file.

If you have additional thoughts, please feel free to bring them up in slack. I appreciate your feedback and input!

@jkleinsc
Copy link
Member

@dswanson I believe we should remove the .route and .controller namespaces

jkleinsc added a commit that referenced this pull request Mar 21, 2016
Merging PR #354 thanks to @dswanson and @baileye
Closes #345
@jkleinsc jkleinsc closed this Mar 21, 2016
@jkleinsc jkleinsc deleted the darinrs-translation-admin-module branch March 21, 2016 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress indicates that issue/pull request is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants