Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Adding ember-cli-content-security-policy with defaults for dev #335

Closed
wants to merge 5 commits into from
Closed

Conversation

pete-the-pete
Copy link
Contributor

PR for #285

This adds the CSP without errors while working locally.

@jkleinsc
Copy link
Member

@pete-the-pete I just ran your PR through tests, and I do see one CSP warning that I wonder if you can resolve:
[Report Only] Refused to load the image 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABQAAAAeCAYAAAAsEj5rAAAAUklEQ…EBEnMgMQ8S8+AqBIl6kKgHiXqQqAeJepBo/z38J/U0uAHlaBkBl9I4GwAAAABJRU5ErkJggg==' because it violates the following Content Security Policy directive: "img-src 'self'".

This comes from pikaday.js which is the date picker we use.

Other than that this PR looks like its good and solves the issues we were having previously.

@pete-the-pete
Copy link
Contributor Author

sure, i'll take a look this evening, sorry I missed it.

@jkleinsc jkleinsc closed this in e9dd2fc Mar 14, 2016
@jkleinsc
Copy link
Member

Fixes #285

@jkleinsc
Copy link
Member

Thanks for the PR @pete-the-pete !

@pete-the-pete
Copy link
Contributor Author

My pleasure, should #285 be closed?

@jkleinsc
Copy link
Member

@pete-the-pete yes, it should be closed. I thought I did close it, but it looks like I didn't

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants