Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Localization for Admin Module #320

Closed
wants to merge 8 commits into from
Closed

Localization for Admin Module #320

wants to merge 8 commits into from

Conversation

renato04
Copy link

@renato04 renato04 commented Mar 1, 2016

address #[281]

This is the localization for the Admin Module.

@jkleinsc
Copy link
Member

jkleinsc commented Mar 1, 2016

Thanks for the PR @renato04. I'll merge and resolve the conflicts.

@jkleinsc jkleinsc closed this in e3df4c7 Mar 1, 2016
@@ -5,6 +5,6 @@
updateButtonText=updateButtonText }}
<div class="alert alert-danger">
<span class="glyphicon glyphicon-warning-sign"></span>
Are you sure you wish to delete the user {{model.name}}?
{{t 'messages.are_you_sure_delete'}}{{model.name}}?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renato04 Quick notice: With ember-i18n we can interpolate values in translation strings (and move the question mark into the string) like this:

// app/locales/en/translations.js
are_you_sure_delete: 'Are you sure you wish to delete the user {{user}}?'
// app/users/delete/template.hbs
{{t 'messages.are_you_sure_delete' user=model.name}}

(I used this technique here cfleschhut@0c6dbb9) :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cfleschhut Thank you for the suggestion i didn't know that, i'll try to use this technique next time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants